From: Mathieu Othacehe <othacehe@gnu.org>
To: Nikolay Korotkiy <sikmir@disroot.org>
Cc: 60622@debbugs.gnu.org
Subject: [bug#60622] [PATCH] gnu: Add nanomq.
Date: Sun, 08 Jan 2023 14:31:04 +0100 [thread overview]
Message-ID: <87tu11up9j.fsf@gnu.org> (raw)
In-Reply-To: <ce59f92df743d81b193de451d5e45614502042c8.1673092288.git.sikmir@disroot.org> (Nikolay Korotkiy's message of "Sat, 7 Jan 2023 15:51:38 +0400")
Hey,
> + (uri (git-reference
> + (url "https://github.com/emqx/nanomq")
> + (commit version)
> + (recursive? #t)))
It looks like nng is packaged by Guix, can it be used?
> + (arguments
> + `(#:tests? #f
You need to justify why the tests are disabled. Is it because there are
no tests, because some do not pass?
> + #:configure-flags (list "-DNNG_ENABLE_TLS=ON" "-DNNG_ENABLE_SQLITE=ON")
> + #:phases (modify-phases %standard-phases
> + (add-after 'unpack 'fix-etc-destination
> + (lambda _
> + (let* ((out (assoc-ref %outputs "out"))
It would be better to use the new gexp based style. You can have a look
to the lldpd package above for an example.
> + (etc (string-append out "/etc")))
> + (substitute* "CMakeLists.txt"
> + (("DESTINATION /etc")
> + (string-append "DESTINATION " etc)))) #t)))))
You can omit the trailing #t.
> + (inputs (list mbedtls-apache sqlite))
> + (synopsis "An ultra-lightweight and blazing-fast MQTT broker for IoT edge")
This a commercial description. Something like: "Lightweight MQTT broker"
would be enough.
> + (description
> + "NanoMQ bases on NNG's asynchronous I/O threading model, with an
> +extension of MQTT support in the protocol layer and reworked transport layer,
> +plus an enhanced asynchronous IO mechanism maximizing the overall capacity.")
It does not really tell what this package does, what is a broker for
instance?
Could you please send an updated version :)? Don't hesitate to ask for
guidance if my comments are unclear.
Thanks,
Mathieu
prev parent reply other threads:[~2023-01-08 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 11:51 [bug#60622] [PATCH] gnu: Add nanomq Nikolay Korotkiy via Guix-patches via
2023-01-08 13:31 ` Mathieu Othacehe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu11up9j.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=60622@debbugs.gnu.org \
--cc=sikmir@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.