all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "André A. Gomes" <andre@atlas.engineer>
To: 63394@debbugs.gnu.org
Subject: bug#63394: guix pack and proot
Date: Mon, 29 May 2023 16:04:59 +0300	[thread overview]
Message-ID: <87ttvvi8zo.fsf@atlas.engineer> (raw)
In-Reply-To: <878rdxcrd0.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi Guix,

I acknowledge the answers provided, but I'd like to emphasize that guix
pack won't run if proot is broken.  This is a critical issue and a
temporary solution is simple enough: disable the tests for the current
proot version packaged.

Please check the patch attached.  


-- 
André A. Gomes
Atlas Engineer - https://atlas.engineer/

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-proot.patch --]
[-- Type: text/x-patch, Size: 1236 bytes --]

From 1c9ece50575f568c824be2274b7b4d874827f0bb Mon Sep 17 00:00:00 2001
From: "Andre A. Gomes" <andremegafone@gmail.com>
Date: Mon, 29 May 2023 16:02:45 +0300
Subject: [PATCH] Fix proot.

---
 gnu/packages/linux.scm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 1be505d949..01f809d980 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -8212,12 +8212,9 @@ (define-public proot
     (supported-systems '("x86_64-linux" "i686-linux"
                          "armhf-linux" "aarch64-linux" "i586-gnu"))
     (arguments
-     ;; Disable the test suite on armhf-linux, as there are too many
-     ;; failures to keep track of (see for example:
-     ;; https://github.com/proot-me/proot/issues/286).
-     `(#:tests? ,(not (or (%current-target-system)
-                          (string-prefix? "armhf"
-                                          (or (%current-system)))))
+     ;; Temporarily disable the tests until https://issues.guix.gnu.org/63284
+     ;; is solved.
+     `(#:tests? #f
        #:make-flags '("-C" "src")
        #:phases (modify-phases %standard-phases
                   (add-after 'unpack 'patch-sources
-- 
2.39.2


  parent reply	other threads:[~2023-05-29 15:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 18:05 bug#63394: Unable to build proot-static locally André A. Gomes
2023-05-09 18:36 ` bug#63394: (no subject) André A. Gomes
2023-05-09 18:43   ` Josselin Poiret via Bug reports for GNU Guix
2023-05-29 13:04 ` André A. Gomes [this message]
2023-05-31 17:20   ` bug#63394: guix pack and proot Josselin Poiret via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttvvi8zo.fsf@atlas.engineer \
    --to=andre@atlas.engineer \
    --cc=63394@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.