From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 63801@debbugs.gnu.org
Cc: Saku Laesvuori <saku@laesvuori.fi>, 63801-done@debbugs.gnu.org
Subject: [bug#63801] [PATCH] gnu: Add yle-dl
Date: Sat, 01 Jul 2023 13:22:48 +0200 [thread overview]
Message-ID: <87ttunj2pj.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20230530092254.16603-1-saku@laesvuori.fi> (Saku Laesvuori via Guix-patches via's message of "Tue, 30 May 2023 12:22:54 +0300")
Hello,
Saku Laesvuori via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/video.scm (yle-dl): New variable.
Applied with the changes below. Thank you.
> * gnu/packages/video.scm: Import (gnu packages python-build).
This information is not necessary in the commit message.
> +(define-public yle-dl
> + (package
Indentation is off. You may want to run "guix style" command prior to
sending a patch (I don't, but I'm opinionated about indentation)
> + (name "yle-dl")
> + (version "20221231")
> + (source (origin
> + ;; PyPI release doesn't include tests
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/aajanki/yle-dl.git")
We usually remove ".git" suffix from URL.
> + (commit "c2a4d2f3926056496f520e289334d345889b51c4")))
We don't use raw hash commits there. The project tags its releases, so
it should be:
(commit version)
> + (add-after 'wrap 'wrap-path
> + (lambda _
> + (wrap-program (string-append #$output "/bin/yle-dl")
> + `("PATH" = (,(string-append #$ffmpeg "/bin")
> + ,(string-append #$wget "/bin"))))))
"#$ffmpeg" and "#$wget" would prevent package transformations. You
should prefer, e.g.,
(string-append #$(this-package-input "ffmpeg") "/bin")
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2023-07-01 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 9:22 [bug#63801] [PATCH] gnu: Add yle-dl Saku Laesvuori via Guix-patches via
2023-07-01 11:22 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttunj2pj.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=63801-done@debbugs.gnu.org \
--cc=63801@debbugs.gnu.org \
--cc=saku@laesvuori.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.