all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 30084@debbugs.gnu.org
Subject: [bug#30084] [PATCH] gnu: Add urho3d.
Date: Fri, 12 Jan 2018 15:01:22 +0100	[thread overview]
Message-ID: <87shbbqiq5.fsf@gnu.org> (raw)
In-Reply-To: <87y3l5ic8f.fsf@gmail.com> (Oleg Pykhalov's message of "Thu, 11 Jan 2018 01:24:16 +0300")

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Thu, 11 Jan 2018 01:14:41 +0300
> Subject: [PATCH] gnu: Add urho3d.
>
> * gnu/packages/game-development.scm (urho3d): New public variable.

[...]

> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* (string-append "../build/Source/ThirdParty"
> +                                         "/SDL/include/generated/SDL_config.h")

IIUC there’s a bundled copy of SDL, right?  Can we instead build against
our SDL?

Ideally, to be safe from bundling, we should “rm -rf ThirdParty” in a
snippet.  Is that possible?

> +               (((string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC"
> +                                " \"libpulse-simple\\.so\\.0\""))
> +                (string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC \""
> +                               (assoc-ref inputs "pulseaudio")
> +                               "/lib/libpulse-simple.so.0"
> +                               "\"")))

Please use a literal string in the ‘substitute*’ pattern (you can use
backslashes to split it on several lines.)

> +    (description "Lightweight, cross-platform 2D and 3D game engine
> +implemented in C++.  Inspired by OGRE and Horde3D.")

Full sentences please!  :-)

  https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html

Could you send an updated path?

Thank you,
Ludo’.

  reply	other threads:[~2018-01-12 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10 22:24 [bug#30084] [PATCH] gnu: Add urho3d Oleg Pykhalov
2018-01-12 14:01 ` Ludovic Courtès [this message]
2018-01-23 13:29   ` Oleg Pykhalov
2018-01-23 14:07     ` Ludovic Courtès
2020-03-22 20:42 ` Leo Famulari
2020-03-23  7:54   ` bug#30084: " Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shbbqiq5.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=30084@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.