From: Pierre Neidhardt <ambrevar@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31178@debbugs.gnu.org, 31176@debbugs.gnu.org
Subject: [bug#31178] [PATCH] gnu: Add inxi.
Date: Mon, 23 Apr 2018 10:03:23 +0530 [thread overview]
Message-ID: <87sh7mr17w.fsf@gmail.com> (raw)
In-Reply-To: <87r2n6gbpg.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
I didn't know Oleg was going to submit a patch, maybe there was some
confusion in the process :p
I've quickly reviewed our two patches. Overall I'd opt for mine :p
- It's the latest version.
- It has more inputs.
I think we should use propagated-inputs and not native-inputs. What do
you think?
I'd opt for Oleg's description however!
One thing I forgot is to add a comment about why I've used
(with-fluids ((%default-port-encoding #f))
It's because the `inxi` file contains some weird character. It was
mentioned before on the mailing list.
--
Pierre Neidhardt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-04-23 4:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 12:38 [bug#31178] [PATCH] gnu: Add inxi Pierre Neidhardt
2018-04-22 21:42 ` [bug#31176] " Ludovic Courtès
2018-04-23 4:33 ` Pierre Neidhardt [this message]
2018-04-23 5:23 ` Oleg Pykhalov
2018-04-23 5:34 ` [bug#31176] " Pierre Neidhardt
2018-04-28 21:27 ` Ludovic Courtès
2018-04-29 17:38 ` Oleg Pykhalov
2018-04-30 10:07 ` Ludovic Courtès
2018-04-30 12:31 ` [bug#31176] " Pierre Neidhardt
2018-04-30 19:18 ` Oleg Pykhalov
2018-05-01 7:27 ` [bug#31178] [bug#31176] " Oleg Pykhalov
2018-05-06 9:42 ` Pierre Neidhardt
2018-05-06 13:31 ` Oleg Pykhalov
2018-05-07 10:14 ` Peter Neidhardt
2018-05-07 15:29 ` Oleg Pykhalov
2018-05-07 19:52 ` [bug#31176] " Peter Neidhardt
2018-05-08 18:11 ` [bug#31178] " Oleg Pykhalov
2018-04-30 13:17 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh7mr17w.fsf@gmail.com \
--to=ambrevar@gmail.com \
--cc=31176@debbugs.gnu.org \
--cc=31178@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.