all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 40543@debbugs.gnu.org
Subject: [bug#40543] [PATCH v2 5/5] gnu: virt-manager: Work towards enabling some tests.
Date: Thu, 16 Apr 2020 09:27:36 +0100	[thread overview]
Message-ID: <87sgh36djb.fsf@cbaines.net> (raw)
In-Reply-To: <873694io3q.fsf@devup.no>

[-- Attachment #1: Type: text/plain, Size: 3240 bytes --]


Marius Bakke <mbakke@fastmail.com> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> * gnu/packages/virtualization.scm (virt-manager)[arguments]: Set #:test-target
>> to "test_ui", replace the 'check phase.
>> [native-inputs]: Add some inputs required for running tests.
>> ---
>>  gnu/packages/virtualization.scm | 25 +++++++++++++++++++++----
>>  1 file changed, 21 insertions(+), 4 deletions(-)
>>
>> diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
>> index be17ec15f0..c8840f345a 100644
>> --- a/gnu/packages/virtualization.scm
>> +++ b/gnu/packages/virtualization.scm
>> @@ -602,9 +602,10 @@ virtualization library.")
>>      (build-system python-build-system)
>>      (arguments
>>       `(#:use-setuptools? #f          ; uses custom distutils 'install' command
>> -       ;; Some of the tests seem to require network access to install virtual
>> -       ;; machines.
>> -       #:tests? #f
>> +       #:test-target "test_ui"
>> +       #:tests? #f                      ; TODO The tests currently fail
>> +                                        ; RuntimeError: Loop condition wasn't
>> +                                        ; met
>>         #:imported-modules ((guix build glib-or-gtk-build-system)
>>                             ,@%python-build-system-modules)
>>         #:modules ((ice-9 match)
>> @@ -651,6 +652,16 @@ virtualization library.")
>>                                 ,(filter identity paths))))
>>                           bin-files))
>>               #t))
>> +         (replace 'check
>> +           (lambda* (#:key tests? #:allow-other-keys)
>> +             (when tests?
>> +               (setenv "HOME" "/tmp")
>> +               (system "Xvfb :1 &")
>> +               (setenv "DISPLAY" ":1")
>> +               ;; Dogtail requires that Assistive Technology support be enabled
>> +               (setenv "GTK_MODULES" "gail:atk-bridge")
>> +               (invoke "dbus-run-session" "--" "python" "setup.py" "test_ui"))
>> +             #t))
>>           (add-after 'install 'glib-or-gtk-compile-schemas
>>             (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))
>>           (add-after 'install 'glib-or-gtk-wrap
>> @@ -679,7 +690,13 @@ virtualization library.")
>>         ("gobject-introspection" ,gobject-introspection)
>>         ("gtk+" ,gtk+ "bin")             ; gtk-update-icon-cache
>>         ("perl" ,perl)                   ; pod2man
>> -       ("intltool" ,intltool)))
>> +       ("intltool" ,intltool)
>> +       ;; The following are required for running the tests
>> +       ("python-dogtail" ,python-dogtail)
>> +       ("xvfb" ,xorg-server)
>> +       ("dbus" ,dbus)
>> +       ("at-spi2-core" ,at-spi2-core)
>> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
>
> Perhaps we should comment these inputs for now so that they won't
> needlessly rebuild this package?

Sure, I'll comment them out.

> Also, this should use 'xorg-server-for-tests'.

I did see xorg-server-for-tests, but the comment said "This package is
intended to be used when building GTK". I guess the same reasoning
applies though, and it is used for packages other than GTK.

I'll make these changes and send some updated patches.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

  reply	other threads:[~2020-04-16  8:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 16:09 [bug#40543] [PATCH 0/4] Work towards enabling virt-manager tests Christopher Baines
2020-04-10 16:21 ` [bug#40543] [PATCH 1/4] gnu: Add python2-pyatspi Christopher Baines
2020-04-10 16:21   ` [bug#40543] [PATCH 2/4] gnu: python2-dogtail: Update to 0.9.11 Christopher Baines
2020-04-10 16:21   ` [bug#40543] [PATCH 3/4] gnu: python2-dogtail: Switch to Python 3, and add Python 2 variant Christopher Baines
2020-04-10 16:21   ` [bug#40543] [PATCH 4/4] gnu: virt-manager: Work towards enabling some tests Christopher Baines
2020-04-10 16:54     ` Marius Bakke
2020-04-15 17:57       ` Christopher Baines
2020-04-10 16:41   ` [bug#40543] [PATCH 1/4] gnu: Add python2-pyatspi Marius Bakke
2020-04-15 17:58     ` Christopher Baines
2020-04-15 17:49 ` [bug#40543] [PATCH v2 1/5] " Christopher Baines
2020-04-15 17:49   ` [bug#40543] [PATCH v2 2/5] gnu: python-pyatspi: Propagate python-pygobject Christopher Baines
2020-04-15 18:37     ` Marius Bakke
2020-04-16  8:28       ` Christopher Baines
2020-04-15 17:49   ` [bug#40543] [PATCH v2 3/5] gnu: python2-dogtail: Update to 0.9.11 Christopher Baines
2020-04-15 17:49   ` [bug#40543] [PATCH v2 4/5] gnu: python2-dogtail: Switch to Python 3, and add Python 2 variant Christopher Baines
2020-04-15 17:49   ` [bug#40543] [PATCH v2 5/5] gnu: virt-manager: Work towards enabling some tests Christopher Baines
2020-04-15 18:46     ` Marius Bakke
2020-04-16  8:27       ` Christopher Baines [this message]
2020-04-16  8:28   ` [bug#40543] [PATCH v3 1/5] gnu: Add python2-pyatspi Christopher Baines
2020-04-16  8:28     ` [bug#40543] [PATCH v3 2/5] gnu: python-pyatspi: Propagate python-pygobject Christopher Baines
2020-04-16  8:28     ` [bug#40543] [PATCH v3 3/5] gnu: python2-dogtail: Update to 0.9.11 Christopher Baines
2020-04-16  8:28     ` [bug#40543] [PATCH v3 4/5] gnu: python2-dogtail: Switch to Python 3, and add Python 2 variant Christopher Baines
2020-04-16  8:28     ` [bug#40543] [PATCH v3 5/5] gnu: virt-manager: Work towards enabling some tests Christopher Baines
2020-05-26  8:03 ` bug#40543: [PATCH 0/4] Work towards enabling virt-manager tests Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgh36djb.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=40543@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.