From: Pierre Langlois <pierre.langlois@gmx.com>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 48977-done@debbugs.gnu.org, Pierre Langlois <pierre.langlois@gmx.com>
Subject: bug#48977: [PATCH 4/4] gnu: Add openjdk16.
Date: Sun, 13 Jun 2021 18:03:39 +0100 [thread overview]
Message-ID: <87sg1ln1ck.fsf@gmx.com> (raw)
In-Reply-To: <20210613180258.75503009@tachikoma.lepiller.eu>
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
Hi Julien,
Julien Lepiller writes:
> Le Sat, 12 Jun 2021 20:54:49 +0100,
> Pierre Langlois <pierre.langlois@gmx.com> a écrit :
>
>> + (arguments
>> + (substitute-keyword-arguments (package-arguments openjdk15)
>> + ((#:phases phases)
>> + `(modify-phases ,phases
>> + (add-after 'unpack 'make-templates-writable
>> + (lambda _
>> + ;; The build system copies a few .template files from
>> the
>> + ;; source directory into the build directory and then
>> modifies
>> + ;; them in-place. So these files have to be writable.
>> + (for-each
>> + (lambda (file)
>> + (invoke "chmod" "u+w" file))
>> + (find-files
>> "src/java.base/share/classes/jdk/internal/misc/"
>> + "\\.template"))
>
> Should be "\\.template$", otherwise the whole series LGTM!
Thanks for the review! Fixed and pushed with
afd4924d6a64c01a1d5138954b9f22c9bd4f4690.
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
prev parent reply other threads:[~2021-06-13 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 19:45 [bug#48977] [PATCH 0/4] Update openjdk 13 and later Pierre Langlois
2021-06-12 19:54 ` [bug#48977] [PATCH 1/4] gnu: openjdk13: Update to 13.0.7 Pierre Langlois
2021-06-12 19:54 ` [bug#48977] [PATCH 2/4] gnu: openjdk14: Update to 14.0.2 Pierre Langlois
2021-06-12 19:54 ` [bug#48977] [PATCH 3/4] gnu: Add openjdk15 Pierre Langlois
2021-06-12 19:54 ` [bug#48977] [PATCH 4/4] gnu: Add openjdk16 Pierre Langlois
2021-06-13 16:02 ` Julien Lepiller
2021-06-13 17:03 ` Pierre Langlois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg1ln1ck.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=48977-done@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.