From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Christine Lemmer-Webber <cwebber@dustycloud.org>
Cc: 50896@debbugs.gnu.org
Subject: bug#50896: emacs-beancount broken, moved to its own project
Date: Wed, 29 Sep 2021 21:30:05 +0200 [thread overview]
Message-ID: <87sfxnxjr6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87v92jp89k.fsf@dustycloud.org> (Christine Lemmer-Webber's message of "Wed, 29 Sep 2021 14:03:20 -0400")
Hello,
Christine Lemmer-Webber <cwebber@dustycloud.org> writes:
> + (let ((commit "dbafe6a73d90c1f64d457b356b9dbb43499f70d5")
> + (revision "0"))
I suggest to mention in a comment that upstream has not made any release
yet.
> + (package
> + (name "emacs-beancount")
> + (version (git-version "0.0.0" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/beancount/beancount-mode")
> + (commit commit)))
> + (sha256
> + (base32
> + "0v9bws2gv5b00x829p7hrcxqgdp7iwxvv1vhfjka81qrw6w1fvjw"))
> + (file-name (git-file-name name version))))
> + (build-system emacs-build-system)
> + (license license:gpl3+)
Nitpick: usually, license field is at the end of the package definition.
> + (home-page "https://github.com/beancount/beancount-mode")
> + (inputs '())
> + (native-inputs '())
You can remove inputs and native-inputs fields, since they are empty.
> + (synopsis "Emacs mode for beancount")
Nitpick: beancount -> Beancount
> + (description
> + "Emacs-beancount is an Emacs mode for the Beancount accounting
> tool."))))
Otherwise, LGTM!
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-09-29 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 18:03 bug#50896: emacs-beancount broken, moved to its own project Christine Lemmer-Webber
2021-09-29 19:30 ` Nicolas Goaziou [this message]
2021-10-13 3:34 ` Christine Lemmer-Webber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfxnxjr6.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=50896@debbugs.gnu.org \
--cc=cwebber@dustycloud.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.