all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: Pierre Langlois <pierre.langlois@gmx.com>
Cc: 51663@debbugs.gnu.org
Subject: [bug#51663] [PATCH] gnu: u-boot: Fix rk3399 boot from emmc.
Date: Fri, 12 Nov 2021 10:26:22 -0800	[thread overview]
Message-ID: <87sfw1fcxd.fsf@yucca> (raw)
In-Reply-To: <87a6igav2l.fsf@gmx.com>

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

On 2021-11-07, Pierre Langlois wrote:
> I'm afraid the last u-boot update broke booting the rockpro64 and
> pinebook-pro from the eMMC card :-/.  Going through the u-boot ML, I saw
> that it was reported [0], and this fix [1] should be applied.
>
> So here's a patch!  I tested it on on both the pinebook-pro and
> rockpro64.
>
> OK to apply?
>
> Thanks,
> Pierre
>
> [0]: https://lists.denx.de/pipermail/u-boot/2021-November/466329.html
> [1]: https://patchwork.ozlabs.org/project/uboot/patch/20211101044347.17822-1-yifeng.zhao@rock-chips.com/
...
> diff --git a/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch
> new file mode 100644
> index 0000000000..f14a9ce104
> --- /dev/null
> +++ b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch
> @@ -0,0 +1,26 @@
> +adapting commit ac804143cf ("mmc: rockchip_sdhci: add phy and clock
> +config for rk3399") to fix the issue "Not found emmc phy device".

I'm a little confused about this comment in the patch... is ac804143cf
the commit which fixed the issue or broke it? is there a reference to an
upstream commit and/or issue that fixes it?

Otherwise, looks good to me!

live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  parent reply	other threads:[~2021-11-12 18:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-07 14:34 [bug#51663] [PATCH] gnu: u-boot: Fix rk3399 boot from emmc Pierre Langlois
2021-11-12 16:07 ` Mathieu Othacehe
2021-11-27 15:04   ` bug#51663: " Pierre Langlois
2021-11-12 18:26 ` Vagrant Cascadian [this message]
2021-11-13 13:35   ` [bug#51663] " Pierre Langlois
2021-11-27 15:06     ` Pierre Langlois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfw1fcxd.fsf@yucca \
    --to=vagrant@debian.org \
    --cc=51663@debbugs.gnu.org \
    --cc=pierre.langlois@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.