all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 53660-done@debbugs.gnu.org
Subject: bug#53660: [PATCH] services/sound: Add a udev extension for the pulseaudio service type.
Date: Tue, 01 Feb 2022 21:54:11 -0500	[thread overview]
Message-ID: <87sft2yo4s.fsf@gmail.com> (raw)
In-Reply-To: <eb7d5072a97e9e967729978bb063bea1f8293b85.camel@gmail.com> (Liliana Marie Prikler's message of "Tue, 01 Feb 2022 20:25:58 +0100")

Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Montag, dem 31.01.2022 um 09:54 -0500 schrieb Maxim Cournoyer:
>> PulseAudio provides udev rules used to adjust the configuration of
>> certain
>> hardware (e.g., sound cards); ensure they get used.
>> 
>> * gnu/services/sound.scm (pulseaudio-service-type): Extend the
>> udev-service-type with the pulseaudio package.
>> ---
>>  gnu/services/sound.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
>> index 1217223a0c..7beca35ffe 100644
>> --- a/gnu/services/sound.scm
>> +++ b/gnu/services/sound.scm
>> @@ -159,7 +159,9 @@ (define pulseaudio-service-type
>>     (extensions
>>      (list (service-extension session-environment-service-type
>>                               pulseaudio-environment)
>> -          (service-extension etc-service-type pulseaudio-etc)))
>> +          (service-extension etc-service-type pulseaudio-etc)
>> +          (service-extension udev-service-type (lambda _
>> +                                                 (list
>> pulseaudio)))))
> You should use const, otherwise SGTM.

Good catch!  Adjusted and pushed as
fff4daa5c2bfbf42c7ad2519f500bd254ce880a8.

Thank you,

Maxim




      reply	other threads:[~2022-02-02  4:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 14:54 [bug#53660] [PATCH] services/sound: Add a udev extension for the pulseaudio service type Maxim Cournoyer
2022-02-01 19:25 ` Liliana Marie Prikler
2022-02-02  2:54   ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sft2yo4s.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=53660-done@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.