From: Xinglu Chen <public@yoctocell.xyz>
To: jgart <jgart@dismail.de>, 53825@debbugs.gnu.org
Cc: jgart <jgart@dismail.de>
Subject: [bug#53825] [PATCH v2] gnu: Add sbase.
Date: Wed, 09 Feb 2022 14:37:44 +0100 [thread overview]
Message-ID: <87sfssw47r.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20220207021717.16045-1-jgart@dismail.de>
[-- Attachment #1: Type: text/plain, Size: 2102 bytes --]
Hi,
jgart schrieb am Sonntag der 06. Februar 2022 um 21:17 -05:
> * gnu/packages/suckless.scm (sbase): New variable.
> ---
>
> Hi Xinglu,
>
> Not sure how dylanaraps got in that url... :)
>
> Something bugged out or I didn't notice.
>
> Anyways here is version 2 with all of your suggestions.
>
> Thanks for the review, Much appreciated!
>
> all best,
>
> jgart
>
> gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 708eb2c338..6aedb2b3ba 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -988,6 +988,39 @@ (define-public snooze
> running a command.")
> (license license:cc0)))
>
> +(define-public sbase
> + ;; There are no tagged releases.
> + (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
> + (revision "0"))
> + (package
> + (name "sbase")
> + (version (git-version "0" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://git.suckless.org/sbase/")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f ; There are no tests.
> + #:make-flags
> + ,#~(list (string-append "CC=" #$(cc-for-target))
> + (string-append "PREFIX=" #$output))
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure))))
> + (home-page "https://core.suckless.org/sbase/")
> + (synopsis "Collection of unix tools that are portable across
> unix-systems")
“unix” isn’t capitalized. Whoever merges the patch can probably do it
for you though; no need to send a new reroll.
Otherwise, LGTM. I didn’t test if all the binaries worked though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2022-02-09 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 17:56 [bug#53825] [PATCH] gnu: Add sbase jgart via Guix-patches via
2022-02-06 18:24 ` Xinglu Chen
2022-02-07 2:17 ` [bug#53825] [PATCH v2] " jgart via Guix-patches via
2022-02-09 13:37 ` Xinglu Chen [this message]
2022-02-09 17:57 ` [bug#53825] [PATCH v3] " jgart via Guix-patches via
2022-07-07 19:57 ` bug#53825: [PATCH] " Maxim Cournoyer
2022-03-20 15:21 ` [bug#53825] " Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfssw47r.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=53825@debbugs.gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.