From: Christopher Baines <mail@cbaines.net>
To: Trev <trev@trevdev.ca>
Cc: 57756@debbugs.gnu.org
Subject: [bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify
Date: Fri, 16 Sep 2022 12:25:37 +0200 [thread overview]
Message-ID: <87sfkrsjf8.fsf@cbaines.net> (raw)
In-Reply-To: <871qsddiof.fsf@codinator.mail-host-address-is-not-set>
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
Trev <trev@trevdev.ca> writes:
> Christopher Baines <mail@cbaines.net> writes:
>
>>> ---
>>> gnu/packages/wm.scm | 24 ++++++++++++++++++++++++
>>> 1 file changed, 24 insertions(+)
>>
>> Hi Trevor,
>>
>> The commit message for adding a package like this one would generally
>> look like:
>>
>> gnu: Add sbcl-stumpwm-notify.
>>
>> * gnu/packages/wm.scm (sbcl-stumpwm-notify): New variable.
>>
>>
>> You're mostly there.
>>
>
> Thank you for this feedback! I had been following the guidelines
> described in the documentation:
>
> https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
>
> It states to write patches in the "changelog" format described here:
>
> https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
>
> Is there documentation somewhere that might help me adapt my strategy
> for future contributions? I do prefer the tighter format you're asking
> for :)
I'm no expert on the changelog format, but I think you were just missing
the descriptive first line of the commit.
Looking at how other commits are written is the only recommendation I
can give for writing commit messages. Also don't worry about it too much
:)
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
prev parent reply other threads:[~2022-09-16 10:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 21:27 [bug#57756] [PATCH 0/2] Add sbcl-xml-emitter Trevor Richards
2022-09-12 21:10 ` [bug#57756] [PATCH 1/2] * gnu/packages/lisp-xyz.scm: " Trevor Richards
2022-09-12 21:10 ` [bug#57756] [PATCH 1/3] gnu: add sbcl-xml-emitter Trevor Richards
2022-09-12 21:10 ` [bug#57756] [PATCH 2/3] gnu: add sbcl-stumpwm-notify Trevor Richards
2022-09-14 16:41 ` [bug#57756] [PATCH 3/3] gnu: sbcl-stumpwm-notify: Fixed missing tests Trevor Richards
2022-09-15 8:40 ` bug#57756: [PATCH 1/3] gnu: add sbcl-xml-emitter Guillaume Le Vaillant
2022-09-12 21:10 ` [bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify Trevor Richards
2022-09-14 7:58 ` Christopher Baines
2022-09-14 16:28 ` Trev
2022-09-16 10:25 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfkrsjf8.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=57756@debbugs.gnu.org \
--cc=trev@trevdev.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.