all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "宋文武 via Guix-patches via" <guix-patches@gnu.org>
To: SeerLite <seerlite@disroot.org>
Cc: 61975@debbugs.gnu.org
Subject: [bug#61975] [PATCH] gnu: i3-wm: Add missing propagated inputs.
Date: Mon, 06 Mar 2023 16:30:19 +0800	[thread overview]
Message-ID: <87sfeip9ic.fsf@envs.net> (raw)
In-Reply-To: <20230305062848.13101-1-seerlite@disroot.org> (seerlite@disroot.org's message of "Sun, 5 Mar 2023 03:28:48 -0300")

SeerLite <seerlite@disroot.org> writes:

> perl-anyevent-i3 is necessary to run i3-save-tree.
>
> * gnu/packages/wm.scm (i3-wm)[propagated-inputs]: Add perl and perl-anyevent-i3.
> ---
>  gnu/packages/wm.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 5b8dbd5c70..8816f110bb 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -356,6 +356,8 @@ (define-public i3-wm
>             startup-notification
>             pango
>             cairo))
> +    (propagated-inputs
> +     (list perl perl-anyevent-i3))

Hello, this can also be done by 'wrap-program' i3-save-tree with
PERL5LIB.  And a wrapper is considered better than propagated-input here
due to the latter will introduce perl and its libraries into user's
profile, which may not be what a typical i3 user want and will also
increase the chance of conflicts in profile.

Could you send an update patch to use 'wrap-program' for i3-save-tree?
Thank you!




  reply	other threads:[~2023-03-06  8:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-05  6:28 [bug#61975] [PATCH] gnu: i3-wm: Add missing propagated inputs SeerLite via Guix-patches via
2023-03-06  8:30 ` 宋文武 via Guix-patches via [this message]
2023-03-07  3:47   ` SeerLite via Guix-patches via
2023-03-07  3:44 ` [bug#61975] [PATCH v2 1/2] gnu: i3-wm: Use new package style SeerLite via Guix-patches via
2023-03-07  3:44   ` [bug#61975] [PATCH v2 2/2] gnu: i3-wm: Add missing inputs for i3-save-tree SeerLite via Guix-patches via
2023-06-09 21:00   ` bug#61975: [PATCH] gnu: i3-wm: Add missing propagated inputs Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfeip9ic.fsf@envs.net \
    --to=guix-patches@gnu.org \
    --cc=61975@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=seerlite@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.