all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Giovanni Biscuolo <g@xelera.eu>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 63534@debbugs.gnu.org, 63371@debbugs.gnu.org
Subject: [bug#63534] [PATCH] gnu: openboard: Update to 1.7-dev-0.47a96e1
Date: Thu, 25 May 2023 15:51:32 +0200	[thread overview]
Message-ID: <87sfbk8qor.fsf@xelera.eu> (raw)
In-Reply-To: <871qj4hdvp.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

Hello,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

[...]

> Nitpick: missing full stops at the end of sentences.

OK, I'll prepare a V2 patch ASAP

>> [arguments]: Fix quazip and poppler library path

sorry: maybe this description is a little bit misleading

> [...]
>
>>                  (substitute* "OpenBoard.pro"
>> -                  (("/usr/include/quazip")
>> -                   (search-input-directory inputs "/include/quazip5"))
>> +                  (("/usr/include/quazip5")

This one is important, it fixes quazip include path (/usr/include/quazip
-> /usr/include/quazip5)

>> +                   (search-input-directory inputs "include/quazip5"))
>>                    (("/usr/include/poppler")
>> -                   (search-input-directory inputs "/include/poppler")))))
>> +                   (search-input-directory inputs "include/poppler")))))
>
> I don't think these changes are warranted. Do they fix something?

No [1], I'll strip this changes from the V2 of this patch

> Otherwise LGTM.

Thanks! Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

  reply	other threads:[~2023-05-25 13:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16  8:27 [bug#63534] [PATCH] gnu: openboard: Update to 1.7-dev-0.47a96e1 Giovanni Biscuolo
2023-05-25 11:03 ` bug#63371: " Nicolas Goaziou
2023-05-25 13:51   ` Giovanni Biscuolo [this message]
2023-05-25 16:59   ` [bug#63534] [PATCH v2] " Giovanni Biscuolo
2023-05-25 20:22     ` bug#63534: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfbk8qor.fsf@xelera.eu \
    --to=g@xelera.eu \
    --cc=63371@debbugs.gnu.org \
    --cc=63534@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.