all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: gemmaro <gemmaro.dev@gmail.com>
Cc: 63739-done@debbugs.gnu.org, 宋文武 <iyzsong@envs.net>,
	"Zhu Zihao" <all_but_last@163.com>
Subject: bug#63739: [PATCH] gnu: Add font-intel-one-mono
Date: Sat, 01 Jul 2023 12:14:00 +0200	[thread overview]
Message-ID: <87sfa8j5w7.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <d67452b9058258d7a02b040e3520e6a459611bc7.1685112598.git.gemmaro.dev@gmail.com> (gemmaro's message of "Fri, 26 May 2023 23:51:28 +0900")

Hello,

gemmaro <gemmaro.dev@gmail.com> writes:

> * gnu/packages/fonts.scm (font-intel-one-mono): New variable.

Applied with changes described below. Thank you.

> +(define-public font-intel-one-mono
> +  (package
> +    (name "font-intel-one-mono")
> +    (version "1.2.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/intel/intel-one-mono")
> +                    (commit "9effabe19a60bdd46cbfbdcc6e81facd8a13b762")))

We prefer tags over raw commit hashes. In this case, the tag is
"V1.2.0", so you need to use instead:

  (string-append "V" version)

If there's no tag, we bind the hash string to a `commit' variable around
the package definition, possibly along with a `revision' if the commit
does not match any version bump,  a and write:

  (commit commit)

> +    (description
> +     "Introducing Intel One Mono, an expressive monospaced font family that's built
> +with clarity, legibility, and the needs of developers in mind.")

The description should consist of complete sentences:

 "This package introduces..."

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2023-07-01 10:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 14:51 [bug#63739] [PATCH] gnu: Add font-intel-one-mono gemmaro
2023-07-01 10:14 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfa8j5w7.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=63739-done@debbugs.gnu.org \
    --cc=all_but_last@163.com \
    --cc=gemmaro.dev@gmail.com \
    --cc=iyzsong@envs.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.