From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: 30601-done@debbugs.gnu.org
Subject: [bug#30601] [PATCH staging] gnu: ninja: Disable tests on armhf.
Date: Tue, 27 Feb 2018 10:05:22 +0100 [thread overview]
Message-ID: <87r2p66bvx.fsf@gnu.org> (raw)
In-Reply-To: <87po4rv7sw.fsf@fastmail.com> (Marius Bakke's message of "Mon, 26 Feb 2018 21:02:07 +0100")
Marius Bakke <mbakke@fastmail.com> skribis:
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Hi!
>>>
>>> Marius Bakke <mbakke@fastmail.com> skribis:
>>>
>>>> * gnu/packages/ninja.scm (ninja)[arguments]: Set #:tests? #f on armhf. Adjust
>>>> CHECK-PHASE accordingly.
>>>> ---
>>>> gnu/packages/ninja.scm | 20 +++++++++++++++-----
>>>> 1 file changed, 15 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/gnu/packages/ninja.scm b/gnu/packages/ninja.scm
>>>> index adb236484..cff2ac38b 100644
>>>> --- a/gnu/packages/ninja.scm
>>>> +++ b/gnu/packages/ninja.scm
>>>> @@ -42,7 +42,15 @@
>>>> (build-system gnu-build-system)
>>>> (native-inputs `(("python" ,python-2)))
>>>> (arguments
>>>> - '(#:phases
>>>> + ;; FIXME: On armhf-linux, Subprocess.TestWithLots fails like this:
>>>> + ;; *** Failure in src/subprocess_test.cc:241
>>>> + ;; ExitSuccess == procs[i]->Finish()
>>>> + ;; See <https://hydra.gnu.org/build/2515522/nixlog/1/raw>.
>>>> + ;; Disable for now.
>>>
>>> Sounds reasonable. Could you also report it upstream? :-)
>>
>> Actually, now that I'm more awake, I found the problem. On most
>> machines this test is skipped because it requires 1025 open files.
>> However, on Hydras armhf machines, this limit is apparently higher.
>>
>> The problem is that the test calls out to /bin/echo. I was able to
>> reproduce it on x86_64 simply by raising the softlimit to 4096.
>>
>> So, I pushed a one-line fix as d0de4c40e24ee52e4382ee2ac82088932ab49099.
>
> Derp. Apparently I wasn't awake enough and managed to patch the wrong
> file when making the commit. The followup in
> 6d796220c417a34100c282a7fa1f9afb6ac00339 fixes it, sorry for the noise.
Heh, thank you!
Ludo’.
prev parent reply other threads:[~2018-02-27 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 3:54 [bug#30601] [PATCH staging] gnu: ninja: Disable tests on armhf Marius Bakke
2018-02-26 17:49 ` Ludovic Courtès
2018-02-26 19:40 ` bug#30601: " Marius Bakke
2018-02-26 20:02 ` [bug#30601] " Marius Bakke
2018-02-27 9:05 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2p66bvx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30601-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.