From: "Clément Lassieur" <clement@lassieur.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31788-done@debbugs.gnu.org
Subject: bug#31788: [PATCH] tests: Honor the return value of 'start-service'.
Date: Wed, 13 Jun 2018 09:13:34 +0200 [thread overview]
Message-ID: <87r2lb6twh.fsf@lassieur.org> (raw)
In-Reply-To: <877en3p4bu.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Clément Lassieur <clement@lassieur.org> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> I’m not entirely sure about things like this:
>>>
>>> - (test-eq "service running"
>>> - 'running!
>>> + (test-assert "service running"
>>> (marionette-eval
>>> '(begin
>>> (use-modules (gnu services herd))
>>> - (start-service 'mcron)
>>> - 'running!)
>>> + (start-service 'mcron))
>>> marionette))
>>>
>>> ‘start-service’ in this case returns a number (the PID), and I think
>>> ‘test-assert’ reports a failure when the value is not exactly #t. Isn’t
>>> it the case?
>>
>> srfi-64 says: "The test passes if the result is true", so I believe
>> test-assert reports a failure only when the value is #f (and maybe on
>> exceptions), because anything else is true in Scheme.
>
> Yeah I know; I had a vague recollection of SRFI-64 behaving funny but
> that’s no longer the case. So I guess you can go ahead.
>
> Thank you!
Pushed, thank you for reviewing!
prev parent reply other threads:[~2018-06-13 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 22:05 [bug#31788] [PATCH] tests: Honor the return value of 'start-service' Clément Lassieur
2018-06-12 19:46 ` Ludovic Courtès
2018-06-12 20:03 ` Clément Lassieur
2018-06-12 20:38 ` Ludovic Courtès
2018-06-12 20:50 ` Clément Lassieur
2018-06-13 6:51 ` Ludovic Courtès
2018-06-13 7:13 ` Clément Lassieur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2lb6twh.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=31788-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.