From: Ricardo Wurmus <rekado@elephly.net>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 38351-done@debbugs.gnu.org
Subject: bug#38351: gnome-characters V2
Date: Sat, 21 Dec 2019 11:16:17 +0100 [thread overview]
Message-ID: <87r20youfi.fsf@elephly.net> (raw)
In-Reply-To: <3fe2fb92b6c3fcf2b5c5dc7b604395d7f75d8dee.camel@disroot.org>
Hi,
> Please find the new patch attached with this email, for gnome-
> characters.
Thank you! I’ve pushed this with commit 4e09f57af8 to the master
branch after a number of small changes:
* applied the patch with “patch -p1 < the-file-that-you-sent.patch”
* removed tabs with M-x untabify
* separated sentences by two spaces
* updated the synopsis
* updated the first sentence of the description
* reflowed the description with M-x fill-paragraph
* changed the home page (so as not to point to the irrelevant design page)
* reflowed the source field
* removed the comments
* moved gettext to the native inputs
* added Python to the native inputs (which is needed for running scripts
in lib)
* set glib-or-gtk? to #t because the program would crash otherwise
* created a commit (using the yasnippet for “add”) and set you as the
author (this would not be needed with git formatted patches)
Thanks!
--
Ricardo
next prev parent reply other threads:[~2019-12-21 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 18:56 [bug#38351] gnome-characters Raghav Gururajan
2019-12-21 3:45 ` [bug#38351] gnome-characters V2 Raghav Gururajan
2019-12-21 5:11 ` Brett Gilio
2019-12-21 10:16 ` Ricardo Wurmus [this message]
2019-12-21 10:33 ` Raghav Gururajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r20youfi.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=38351-done@debbugs.gnu.org \
--cc=raghavgururajan@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.