From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Leo Prikler <leo.prikler@student.tugraz.at>, 36376@debbugs.gnu.org
Subject: bug#36376: Application menu of desktop environment not automatically updated
Date: Fri, 06 Nov 2020 13:56:10 -0500 [thread overview]
Message-ID: <87r1p6tiut.fsf@gmail.com> (raw)
In-Reply-To: <878sbexylp.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 06 Nov 2020 17:02:26 +0100")
Hey Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> From a79645c565e56ac201e66936d9f9883ad9387b06 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Thu, 5 Nov 2020 00:24:29 -0500
>> Subject: [PATCH] gdesktopappinfo: Fix monitoring of a Guix profile
>> XDG_DATA_DIR.
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> Fixes <https://issues.guix.gnu.org/35594>.
>>
>> Treat the $HOME/.guix-profile/share and /run/current-system/share
>> XDG_DATA_DIRS file names specially so that the inotify-based monitors
>> placed by GLib monitor their parent link rather than an immutable
>> directory.
>>
>> Co-authored by Ludovic Courtès <ļudo@gnu.org>.
> ^
> This is LATIN SMALL LETTER L WITH CEDILLA. :-)
>
>> ---
>> gio/gdesktopappinfo.c | 17 +++++++++++++++--
>> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> I like that it’s short and sweet, nice!
I thought too, but it doesn't work, because these entries never make it
to XDG_DATA_DIRS in the first place, at least for the system profile.
I also gave a try to 1) a modified version of your patch that added
support for /run/current-system and 2) your patch unmodified with
inconclusive results so far.
I did see things being scanned in response to /run/current-system
changing, but I believe this was because I goofed up the dir path to
"/run/current-system/share" (it should have been
""/run/current-system/profile/share"), and there's some code
gdesktopappinfo.c (desktop_file_dir_get_alternative_dir) that sets the
monitored directory to a parent when the directory doesn't exist.
In either version, strace failed to show any activity upon recreating
the ~/.guix-profile (that is /root/.guix-profile since I was testing as
root in the VM) link, different to what you had found.
So, to be continued...
Maxim
next prev parent reply other threads:[~2020-11-06 18:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 14:12 bug#36376: Application menu of desktop environment not automatically updated Ludovic Courtès
2020-11-03 22:46 ` Ludovic Courtès
2020-11-03 23:28 ` Leo Prikler
2020-11-04 21:41 ` bug#35594: " Maxim Cournoyer
2020-11-04 22:15 ` Ludovic Courtès
2020-11-05 6:38 ` Maxim Cournoyer
2020-11-06 16:02 ` Ludovic Courtès
2020-11-06 18:56 ` Maxim Cournoyer [this message]
2020-11-10 15:23 ` Ludovic Courtès
2020-11-10 17:48 ` bug#35594: " zimoun
2020-11-10 21:23 ` Ludovic Courtès
2020-11-12 15:56 ` bug#35594: " Ludovic Courtès
2020-11-13 20:38 ` bug#36376: " Ludovic Courtès
2020-11-17 4:57 ` Maxim Cournoyer
2020-11-17 9:08 ` Ludovic Courtès
2020-11-18 4:34 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1p6tiut.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=36376@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.