From: Jan Nieuwenhuizen <janneke@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Vagrant Cascadian <vagrant@debian.org>,
guix-devel@gnu.org, bug-mes@gnu.org
Subject: Re: Update on wip-arm-bootstrap
Date: Mon, 22 Feb 2021 07:14:29 +0100 [thread overview]
Message-ID: <87r1l8ljcq.fsf@gnu.org> (raw)
In-Reply-To: <20210222020330.74832a2b@scratchpost.org> (Danny Milosavljevic's message of "Mon, 22 Feb 2021 02:03:30 +0100")
Danny Milosavljevic writes:
Hello Danny,
> Nice!
>
> Patch review:
>
>>+#if __ARM_EABI__
>>+#define CLEAR_CACHE(BEG,END) \
>>+{ \
>>+ register unsigned long _beg __asm ("a1") = (unsigned long)(BEG); \
>>+ register unsigned long _end __asm ("a2") = (unsigned long)(END); \
>>+ register unsigned long _flg __asm ("a3") = 0; \
>>+ __asm __volatile ("mov r7, 0x9f0002\n\t" \
>
> should be mov r7, 0xf0002 in EABI.
> (SWI #(0x900000 + syscallnr) is for OABI syscalls only)
Ok, great; that could help!
>>* sysdeps/unix/sysv/linux/arm/brk.c (__brk): Likewise.Likewise.
>
> Duplicate "Likewise".
>
> Otherwise LGTM!
Thanks. Testing a fixup now (currently only on my branch @gitlab).
>>But something like puts or printf segfaults "Illegal
>>instruction" in strlen:
>
>>--8<---------------cut here---------------start------------->8---
>>(gdb) disas /r
>>Dump of assembler code for function strlen:
>> 0x0000d160 <+0>: 03 10 c0 e3 bic r1, r0, #3
>>=> 0x0000d164 <+4>: 04 20 91 e4 ldr r2, [r1], #4
>>--8<---------------cut here---------------end--------------->8---
>
> Hmm... looks good to me? Weird.
Yes...
> I'm building it right now and will have a look.
Great, thanks!
Janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
prev parent reply other threads:[~2021-02-22 6:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 9:25 Update on wip-arm-bootstrap Jan Nieuwenhuizen
2021-02-18 17:26 ` Ludovic Courtès
2021-02-21 18:17 ` Jan Nieuwenhuizen
2021-02-22 1:03 ` Danny Milosavljevic
2021-02-18 17:48 ` Vagrant Cascadian
2021-02-18 21:52 ` Jan Nieuwenhuizen
2021-02-19 4:23 ` Danny Milosavljevic
2021-02-19 6:17 ` Jan Nieuwenhuizen
2021-02-21 18:28 ` Jan Nieuwenhuizen
2021-02-22 1:03 ` Danny Milosavljevic
2021-02-22 1:50 ` Danny Milosavljevic
2021-02-22 6:01 ` Jan Nieuwenhuizen
2021-02-22 17:09 ` Danny Milosavljevic
2021-02-22 17:34 ` Danny Milosavljevic
2021-02-22 6:14 ` Jan Nieuwenhuizen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1l8ljcq.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=bug-mes@gnu.org \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.