all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Sughosha <Sughosha@proton.me>
Cc: 58681-done@debbugs.gnu.org
Subject: bug#58681: [PATCH v2] gnu: Add synthpod.
Date: Wed, 25 Jan 2023 00:24:12 +0100	[thread overview]
Message-ID: <87r0vjcy60.fsf@elephly.net> (raw)
In-Reply-To: <eliH3oT8t2wMrICbqjyWfhr8eefnVpUx9vKeXY_6nsIBZHz0dhZrvKeOcNxZpgHvzzUV75pEj6ExLKDcmJGMz_zxz5KTbJty6VbXsQZJpXQ=@proton.me>


Sughosha <Sughosha@proton.me> writes:

> Thanks for reviewing the patch and improving it.
>
>> We should probably also wrap the scripts to set PATH to where “grep”,
> “coreutils”, “sed”, and “gawk” are found, but I wasn’t able to add (gnu
> packages gawk) to the imports of (gnu packages music).
>
> This is not the only package requiring such basic programs like "sed",
> "grep" etc but not wrapped or listed in inputs. The other such package that
> I am aware of is ardour, which also requires these programs. I tried
> running ardour in a guix shell with --emulate-fhs, then found that ardour
> could not start because these programs were not found in the PATH. So I am
> not sure if it is required to add these programs to inputs or to wrap them.

To me this means that we should also fix ardour, not that we should
ignore the problem in other packages :)

>> Unfortunately, the program crashes because it can’t find the LV2 files
> for Synthpod itself:
>
> I fixed it partially. The binaries are confusing. `synthpod_ui` seems like
> not to be run manually. The way that I found to run the ui is
> `synthpod_alsa -g` or `synthpod_jack -g`.
>
> Strangely, with the attatched new v3 patch, the program starts only if
> installed to guix profile (or maybe something else like guix home, not
> tested). Just by building, the program searches for "manifest.ttl" file
> in the current working directory and fails to start.

That’s odd, but perhaps it’s the default of an LV2 library that synthpod
uses.

The patch looks good enough to me, so I applied it.  Feel free to
revisit it at a later point to address the remaining minor issues.

Thank you!

-- 
Ricardo




      reply	other threads:[~2023-01-24 23:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 11:19 [bug#58681] [PATCH] gnu: Add synthpod Sughosha via Guix-patches via
2022-10-25  9:25 ` Christopher Baines
2023-01-06 14:27 ` [bug#58681] [PATCH v2] " Sughosha via Guix-patches via
2023-01-22 22:58 ` Ricardo Wurmus
2023-01-23 21:10   ` Sughosha via Guix-patches via
2023-01-24 23:24     ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0vjcy60.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=58681-done@debbugs.gnu.org \
    --cc=Sughosha@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.