From: "Ludovic Courtès" <ludo@gnu.org>
To: Bruno Victal <mirai@makinata.eu>
Cc: 61789@debbugs.gnu.org
Subject: [bug#61789] [PATCH 00/27] Deprecate old-style services.
Date: Fri, 03 Mar 2023 17:40:49 +0100 [thread overview]
Message-ID: <87r0u5vlda.fsf_-_@gnu.org> (raw)
In-Reply-To: <dfe7a382916396d1de4f6f2e8eeccf548a8857f5.1677350249.git.mirai@makinata.eu> (Bruno Victal's message of "Sat, 25 Feb 2023 18:57:56 +0000")
Hi,
Bruno Victal <mirai@makinata.eu> skribis:
> * doc/guix.texi (Base Services): Replace pam-limits-service with pam-limits-service-type.
> * gnu/packages/benchmark.scm (python-locust)[description]: Update index anchor to manual.
> * gnu/services/base.scm (pam-limits-service-type): Accept both lists and
> file-like objects for compatibility.
> (pam-limits-service): Deprecate procedure.
[...]
> @lisp
> -(pam-limits-service
> +(service pam-limits-service-type
> (list
> (pam-limits-entry "@@realtime" 'both 'rtprio 99)
> (pam-limits-entry "@@realtime" 'both 'memlock 'unlimited)))
Would be nice to indent the service value. :-)
> (define pam-limits-service-type
> - (let ((security-limits
> - ;; Create /etc/security containing the provided "limits.conf" file.
> - (lambda (limits-file)
> - `(("security/limits.conf"
> - ,limits-file))))
> - (pam-extension
> + (let ((pam-extension
> (lambda (pam)
> (let ((pam-limits (pam-entry
> (control "required")
> (module "pam_limits.so")
> - (arguments '("conf=/etc/security/limits.conf")))))
> + (arguments
> + '("conf=/etc/security/limits.conf")))))
> (if (member (pam-service-name pam)
> '("login" "greetd" "su" "slim" "gdm-password" "sddm"
> "sudo" "sshd"))
> @@ -1602,7 +1598,26 @@ (define pam-limits-service-type
> (inherit pam)
> (session (cons pam-limits
> (pam-service-session pam))))
> - pam)))))
> + pam))))
> +
> + ;; XXX: Using file-like objects is deprecated, use lists instead.
> + ;; This is to be reduced into the list? case when the deprecated
> + ;; code gets removed.
> + ;; Create /etc/security containing the provided "limits.conf" file.
> + (security-limits
> + (match-lambda
> + ((? file-like? obj)
> + (warning (G_ "Using file-like value for 'pam-limits-service-type'
> +is deprecated~%"))
> + obj)
> + ((? list? lst)
> + `(("security/limits.conf"
> + ,(plain-file "limits.conf"
> + (string-join (map pam-limits-entry->string lst)
> + "\n" 'suffix)))))
> + (_ (report-error
> + (G_ "invalid input for 'pam-limits-service-type'~%"))))))
Maybe this change (from file-like to list) should be done separately,
for clarity?
Also note that ‘report-error’ prints an error but keeps going. You
probably want to use (raise (formatted-message …)) instead.
Ludo’.
next prev parent reply other threads:[~2023-03-03 16:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 18:53 [bug#61789] [PATCH 00/27] Deprecate old-style services Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 01/27] services: base: Deprecate 'host-name-service' procedure Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 02/27] services: base: Deprecate 'login-service' procedure Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 03/27] services: base: Deprecate 'mingetty-service' procedure Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 04/27] services: base: Deprecate 'agetty-service' procedure Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 05/27] doc: kmscon-service-type: Use @defvar @-command Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 06/27] services: base: Deprecate 'nscd-service' procedure Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 07/27] services: base: Deprecate 'syslog-service' procedure Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 08/27] services: base: Deprecate 'udev-service' procedure Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 09/27] services: base: Deprecate 'rngd-service' procedure Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 10/27] services: base: Deprecate 'pam-limits-service' procedure Bruno Victal
2023-03-03 16:40 ` Ludovic Courtès [this message]
2023-02-25 18:57 ` [bug#61789] [PATCH 11/27] services: tor: Deprecate 'tor-hidden-service' procedure Bruno Victal
2023-03-03 16:43 ` [bug#61789] ‘tor-hidden-service’ deprecation Ludovic Courtès
2023-03-05 17:51 ` Bruno Victal
2023-03-06 16:05 ` Ludovic Courtès
2023-02-25 18:57 ` [bug#61789] [PATCH 12/27] services: ssh: Deprecate 'lsh-service' procedure Bruno Victal
2023-02-25 18:57 ` [bug#61789] [PATCH 13/27] services: ssh: Deprecate 'dropbear-service' procedure Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 14/27] services: xorg: Deprecate 'screen-locker-service' procedure Bruno Victal
2023-03-03 16:45 ` [bug#61789] ‘screen-locker-service’ deprecation Ludovic Courtès
2023-03-06 14:36 ` Bruno Victal
2023-03-06 22:32 ` Ludovic Courtès
2023-02-25 18:58 ` [bug#61789] [PATCH 15/27] services: desktop: Deprecate 'elogind-service' procedure Bruno Victal
2023-03-03 16:48 ` [bug#61789] ‘elogind-configuration’ documentation needs love Ludovic Courtès
2023-02-25 18:58 ` [bug#61789] [PATCH 16/27] services: elogind-configuration: Do not ignore 'handle-hibernate-key' by default Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 17/27] services: desktop: Deprecate 'accountsservice-service' procedure Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 18/27] services: dbus: Deprecate 'polkit-service' procedure Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 19/27] services: desktop: Deprecate 'udisks-service' procedure Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 20/27] services: desktop: Deprecate 'geoclue-service' procedure Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 21/27] services: desktop: Deprecate 'bluetooth-service' procedure Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 22/27] services: mail: Deprecate 'dovecot-service' procedure Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 23/27] services: vpn: Deprecate 'openvpn-client-service' & 'openvpn-server-service' procedures Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 24/27] services: lirc: Deprecate 'lirc-service' procedure Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 25/27] services: spice: Deprecate 'spice-vdagent-service' procedure Bruno Victal
2023-02-25 18:58 ` [bug#61789] [PATCH 26/27] services: dict: Deprecate 'dicod-service' procedure Bruno Victal
2023-03-03 16:52 ` [bug#61789] ‘dicod-service’ deprecation Ludovic Courtès
2023-02-25 18:58 ` [bug#61789] [PATCH 27/27] services: dbus: Deprecate 'dbus-service' procedure Bruno Victal
2023-03-03 17:09 ` [bug#61789] [PATCH 00/27] Deprecate old-style services Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0u5vlda.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=61789@debbugs.gnu.org \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.