all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: Kaelyn <kaelyn.alexi@protonmail.com>, 63393@debbugs.gnu.org
Subject: [bug#63393] [PATCH 0/2] Fix libstdc++.so and gcc-toolchain
Date: Thu, 11 May 2023 15:38:01 +0200	[thread overview]
Message-ID: <87r0rn2dl2.fsf_-_@gnu.org> (raw)
In-Reply-To: <ce970fb1a1f436542b5602013369654c63f100f4.1683650835.git.zimon.toutoune@gmail.com> (Simon Tournier's message of "Tue, 9 May 2023 19:04:05 +0200")

Hi,

Simon Tournier <zimon.toutoune@gmail.com> skribis:

> * gnu/packages/commencement.scm (make-gcc-toolchain): Add 'lib' outputs.

[...]

>                                      (filter-map (match-lambda
>                                                    (("libc-debug" . _) #f)
>                                                    (("libc-static" . _) #f)
> +                                                  (("gcc-lib" . _) #f)
> +                                                  (("gcc-debug" . _) #f)

I would include gcc:lib in “out” (thus not adding a “lib” output to
‘gcc-toolchain’).

Yes, gcc:lib includes *.a and *.la, but those are already part of the
‘gcc-toolchain’ closure:

--8<---------------cut here---------------start------------->8---
$ guix size gcc-toolchain |head -6
store item                                                       total    self
/gnu/store/jv78mm3dmr6fl2hhy1bkbhfpm702v3gq-gcc-12.3.0             292.6   169.4  41.2%
/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38           95.5    54.9  13.4%
/gnu/store/g8p09w6r78hhkl2rv1747pcp9zbk6fxv-guile-3.0.9            134.0    53.1  12.9%
/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35              40.6    38.8   9.4%
/gnu/store/gmv6n5vy5qcsn71pkapg2hnknyn1p7g3-gcc-12.3.0-lib          76.8    36.2   8.8%
--8<---------------cut here---------------end--------------->8---

However, I’d leave out gcc:debug because (0) it’s unrelated :-), (1)
‘gcc-final’ has no “debug” output, and (2) it’s really for a niche
(folks developing compiler plugins, typically).

I’d also leave out the /lib directory of Binutils, which is again rarely
useful.

WDYT?

Thanks,
Ludo’.




  reply	other threads:[~2023-05-11 13:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 16:58 [bug#63393] [PATCH 0/2] Fix libstdc++.so and gcc-toolchain Simon Tournier
2023-05-09 17:04 ` [bug#63393] [PATCH 1/2] gnu: gcc-toolchain: Do not use gcc-final Simon Tournier
2023-05-09 17:04 ` [bug#63393] [PATCH 2/2] gnu: make-gcc-toolchain: Add 'lib' outputs Simon Tournier
2023-05-11 13:38   ` Ludovic Courtès [this message]
2023-05-09 18:50 ` [bug#63393] [PATCH 0/2] Fix libstdc++.so and gcc-toolchain Kaelyn via Guix-patches via
2023-07-16 18:33 ` John Kehayias via Guix-patches via
2024-01-16 22:16   ` Maxim Cournoyer
2024-01-24 17:08     ` Ludovic Courtès
2024-01-24 19:11       ` Maxim Cournoyer
2024-04-03 19:22   ` John Kehayias via Guix-patches via
2024-04-03 19:26     ` [bug#63393] [PATCH V2 1/2] gnu: gcc-toolchain: Do not use gcc-final John Kehayias via Guix-patches via
2024-04-03 19:27     ` [bug#63393] [PATCH V2 2/2] gnu: make-gcc-toolchain: Add gcc:lib John Kehayias via Guix-patches via
2024-04-10 21:21     ` [bug#63393] [PATCH 0/2] Fix libstdc++.so and gcc-toolchain Ludovic Courtès
2024-04-17  5:15       ` bug#63393: " John Kehayias via Guix-patches via
2023-10-26 12:11 ` [bug#63393] " Isaac van Bakel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0rn2dl2.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=63393@debbugs.gnu.org \
    --cc=kaelyn.alexi@protonmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.