[bug#66408] [PATCH v5] gnu: icecat: Support Guix packaged extensions and native manifests.

["Clément Lassieur" <clement@lassieur.org>]

Hey Mathieu,

>> +              (let* ((id #$(assq-ref properties 'id))
>
> id is maybe a bit generic?

Done.

>> +                     (firefox (in-vicinity (assoc-ref outputs "firefox") id))
>> +                     (xpi (assoc-ref outputs "xpi"))
>> +                     (chromium (assoc-ref outputs "chromium")))
>>                  (install-file "dist/build/uBlock0.firefox.xpi"
>>                                (string-append xpi "/lib/mozilla/extensions"))
>>                  (copy-recursively "dist/build/uBlock0.firefox" firefox)
>> @@ -142,3 +146,6 @@ (define ublock-origin
>>  
>>  (define-public ublock-origin/chromium
>>    (make-chromium-extension ublock-origin "chromium"))
>> +
>> +(define-public ublock-origin/icecat
>> +  (make-icecat-extension ublock-origin "firefox"))
>
> It does not appear clearly that one has to install ublock-origin-icecat
> here. We have the same issue for ublock-origin-chromium though.

Indeed!  That's a small change that should be in another patch I
believe.

>> diff --git a/gnu/packages/patches/icecat-compare-paths.patch b/gnu/packages/patches/icecat-compare-paths.patch
>> new file mode 100644
>> index 000000000000..9205899dc0c4
>> --- /dev/null
>> +++ b/gnu/packages/patches/icecat-compare-paths.patch
>
> You could add a small header explaining the content of that patch, ...

Done.

>> --- /dev/null
>> +++ b/gnu/packages/patches/icecat-use-system-wide-dir.patch
>
> ..., as well as that one.

Done.

> I tried a guix shell icecat ublock-origin-icecat and it worked perfectly
> :) It is also very appreciated to have a pre-built icecat by the QA :).

Thanks for the review!
Clément