Re: [PATCH] guix: refresh: Use bags.

[ludo@gnu.org (Ludovic Courtès)]

Eric Bavier <ericbavier@gmail.com> skribis:

> Ludovic Courtès writes:
>
>> I’m surprised gzip, diffutils, patch, and tar are very low, even though
>> they’re part of %final-inputs.  Conversely, bzip2 (also part of
>> %final-inputs) is higher.
>>
>> Any idea?
>
> I think this is because fold-packages only looks at packages that are
> exported by a module.  Many of the packages in %final-inputs are not
> exported.
>
> While the vhash returned by (@ (gnu packages) package-dependencies)
> includes dependency lists for packages in %final-inputs, guix refresh
> uses find-package-by-name to get the packages that are used as lookup
> keys, and find-package-by-name only returns packages that can be found
> with fold-packages.  Uff da.

Ah OK.  It’s not that bad, it just means that some packages are omitted
from the list.

Of course it would be good to use the full DAG.  For that we’d need
something that uses ‘fold-packages’ to get the “entry points” of the
DAG, and then traverses it all to also get the private packages.

From there we could perhaps build a ‘fold-package*’ that would iterate
on the whole DAG.

WDYT?

> One, possibly ugly to implement, solution would be to merge hash entries
> of packages that have the same package-full-name, since the output is
> produced in that format already.

Instead, what about keeping things as is, but also showing the
‘package-location’ of each item?

Thanks,
Ludo’.