all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ng0 <ng0@libertad.pw>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: help-guix@gnu.org
Subject: Re: Seeking advice: preparing releases on GuixSD.
Date: Mon, 26 Dec 2016 12:41:51 +0000	[thread overview]
Message-ID: <87pokelv5c.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87mvfknq1e.fsf@elephly.net>

Ricardo Wurmus <rekado@elephly.net> writes:

> ng0 <ng0@libertad.pw> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> writes:
> […]
>>> From af81a0a3c796af583ec88dd4bc8d2e8a742c58fa Mon Sep 17 00:00:00 2001
>>> From: Ricardo Wurmus <rekado@elephly.net>
>>> Date: Sat, 24 Dec 2016 11:12:45 +0100
>>> Subject: [PATCH] gnu: Add roffit.
>>>
>>> * gnu/packages/groff.scm (roffit): New variable.
> […]
>>> +;; There are no releases, so we take the latest commit.
>>> +(define-public roffit
>>> +  (let ((commit "e5228388e3faf2b7f1ae5bd048ad46ed565304c6")
>>> +        (revision "1"))
>>> +    (package
>>> +      (name "roffit")
>>> +      (version (string-append "0.11-" revision "." (string-take commit 9)))
>>> +      (source (origin
>>> +                (method git-fetch)
>>> +                (uri (git-reference
>>> +                      (url "https://github.com/bagder/roffit.git")
>>> +                      (commit commit)))
>>> +                (file-name (string-append "roffit-" commit "-checkout"))
>>> +                (sha256
>>> +                 (base32
>>> +                  "1y7ndbqciy7h0khlpi1bv4v1614vhybnmm4jysj6fwxkw9cwv1nc"))))
>>> +      (build-system gnu-build-system)
>>> +      (arguments
>>> +       `(#:test-target "test"
>>> +         #:make-flags
>>> +         (list (string-append "INSTALLDIR="
>>> +                              (assoc-ref %outputs "out") "/bin"))
>>> +         #:phases
>>> +         (modify-phases %standard-phases
>>> +           (delete 'configure)
>>> +           (add-before 'install 'pre-install
>>> +             (lambda* (#:key outputs #:allow-other-keys)
>>> +               (mkdir-p (string-append (assoc-ref outputs "out")
>>> +                                       "/bin"))
>>> +               #t)))))
>>
>> My only difference is in the (arguments), where I do:
>>
>>       (arguments
>>        `(#:test-target "test"
>>          #:phases
>>          (modify-phases %standard-phases
>>            (replace 'configure ; No configure phase
>>              (lambda* (#:key outputs #:allow-other-keys)
>>                (let* ((out  (assoc-ref outputs "out"))
>>                       (bin  (string-append out "/bin/")))
>>                  (substitute* "Makefile"
>>                    (("/usr/local/bin")
>>                     bin))
>
> That’s not necessary, because we can override INSTALLDIR.

Okay, I didn't give my package much attention it was done in 5
minutes.

>>                (mkdir-p bin))))
>>            (add-after 'install 'wrap-programs
>>              (lambda* (#:key outputs #:allow-other-keys)
>>                ;; Make sure all executables in "bin" find the Perl modules
>>                ;; provided by this package at runtime.
>>                (let* ((out  (assoc-ref outputs "out"))
>>                       (bin  (string-append out "/bin/"))
>>                       (path (getenv "PERL5LIB")))
>>                  (for-each (lambda (file)
>>                              (wrap-program file
>>                                `("PERL5LIB" ":" prefix (,path))))
>>                            (find-files bin "\\.*$"))
>>                  #t))))))
>
> Why would this be necessary?  There are no Perl packages among the
> inputs.

True. Okay, thanks for pushing this.
That leaves one question open from my previous message (about
ltmain.sh), but I don't need/want an immediate reply.

> -- 
> Ricardo
>   
>   GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
>   http://elephly.net
>
>

-- 
♥Ⓐ  ng0
PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org

      reply	other threads:[~2016-12-26 12:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23 13:35 Seeking advice: preparing releases on GuixSD ng0
2016-12-23 17:04 ` Alex Kost
2016-12-23 17:34   ` ng0
2016-12-24 10:13 ` Ricardo Wurmus
2016-12-24 14:45   ` ng0
2016-12-24 15:32     ` Ricardo Wurmus
2016-12-24 16:13       ` ng0
2016-12-24 16:23         ` Ricardo Wurmus
2016-12-24 16:34           ` ng0
2016-12-26 13:58             ` Ricardo Wurmus
2016-12-26 14:27               ` ng0
2016-12-30 23:34       ` Ludovic Courtès
2017-01-31 21:03         ` bug#25304: " Ludovic Courtès
2017-04-21 14:30         ` bug#25304: Libtool’s ltmain.sh still contains a /gnu/store shebang Ludovic Courtès
2020-11-13 15:32           ` Miguel Ángel Arruga Vivas
2020-11-15 11:08             ` Ludovic Courtès
2020-11-16 16:17               ` Miguel Ángel Arruga Vivas
2016-12-24 22:26   ` Seeking advice: preparing releases on GuixSD ng0
2016-12-25 12:37     ` Ricardo Wurmus
2016-12-26 12:41       ` ng0 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pokelv5c.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me \
    --to=ng0@libertad.pw \
    --cc=help-guix@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.