From: "Clément Lassieur" <clement@lassieur.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 33265@debbugs.gnu.org
Subject: [bug#33265] [WIP RFC] services: Add file system monitor service.
Date: Mon, 05 Nov 2018 10:36:00 +0100 [thread overview]
Message-ID: <87pnvjn9xb.fsf@lassieur.org> (raw)
In-Reply-To: <20181105031833.7917-1-dannym@scratchpost.org>
Hi Danny,
I don't have time to do a proper review, but just one comment:
Danny Milosavljevic <dannym@scratchpost.org> writes:
> + (test-assert "file system monitor running"
> + (marionette-eval
> + '(begin
> + (use-modules (gnu services herd))
> + (match (start-service 'monitor-file-system)
> + (#f #f)
> + (('service response-parts ...)
> + (match (assq-ref response-parts 'running)
> + ((pid) (number? pid))))))
> + marionette))
How is that better than:
(test-assert "file system monitor running"
(marionette-eval
'(begin
(use-modules (gnu services herd))
(start-service 'monitor-file-system))
marionette))
'start-service' should return #f if the service fails to start.
Cheers,
Clément
next prev parent reply other threads:[~2018-11-05 9:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 3:18 [bug#33265] [WIP RFC] services: Add file system monitor service Danny Milosavljevic
2018-11-05 3:45 ` [bug#33265] [WIP RFC v2] " Danny Milosavljevic
2018-11-05 3:51 ` [bug#33265] [WIP RFC v3] services: Add file system monitoring service Danny Milosavljevic
2018-11-05 9:16 ` swedebugia
2018-11-05 9:41 ` [bug#33265] [WIP RFC v4] " Danny Milosavljevic
2018-11-10 22:19 ` Ludovic Courtès
2018-11-11 0:12 ` Danny Milosavljevic
2018-11-11 0:13 ` Danny Milosavljevic
2018-11-11 11:25 ` Ludovic Courtès
2018-11-11 12:30 ` Danny Milosavljevic
2018-11-11 12:50 ` Danny Milosavljevic
2018-11-11 13:22 ` Ludovic Courtès
2018-11-05 9:36 ` Clément Lassieur [this message]
2018-11-11 0:15 ` [bug#33265] [WIP RFC] services: Add file system monitor service Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnvjn9xb.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=33265@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.