all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: 34433@debbugs.gnu.org
Subject: [bug#34433] [PATCH 1/1] gnu: Fix aegisub.
Date: Mon, 11 Feb 2019 13:42:44 +0100	[thread overview]
Message-ID: <87pnrylcmz.fsf@elephly.net> (raw)
In-Reply-To: <20190211133641.7e448f1d@alma-ubu>


Hi Björn,

> * gnu/packages/video.scm (aegisub)[arguments]: Add phase to fix
> boost headers.

Thanks!

> +         (add-after 'unpack 'fix-boost-headers
> +               (lambda _
> +                 (for-each
> +                  (lambda (f)
> +                    (substitute* f
> +                      (("#include <boost/gil/gil_all.hpp>")
> +                       "#include <boost/gil.hpp>")))
> +                  (list
> +                   "src/subtitles_provider_libass.cpp"
> +                   "src/colour_button.cpp"
> +                   "src/video_provider_dummy.cpp"
> +                   "./src/video_frame.cpp"))
> +                 #t)))))

It’s better to give “substitute*” a list of files instead of using
“for-each”.

      (lambda _
        (substitute* '("src/subtitles_provider_libass.cpp"
                       "src/colour_button.cpp"
                       "src/video_provider_dummy.cpp"
                       "src/video_frame.cpp")
          (("#include <boost/gil/gil_all.hpp>")
           "#include <boost/gil.hpp>"))
        #t)

Okay with these changes.

-- 
Ricardo

  reply	other threads:[~2019-02-11 12:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 12:36 [bug#34433] [PATCH 1/1] gnu: Fix aegisub Björn Höfling
2019-02-11 12:42 ` Ricardo Wurmus [this message]
2019-02-13  9:44   ` bug#34433: " Björn Höfling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnrylcmz.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=34433@debbugs.gnu.org \
    --cc=bjoern.hoefling@bjoernhoefling.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.