all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 42192@debbugs.gnu.org
Subject: [bug#42192] [PATCH 0/3] Improve launchpad updater
Date: Mon, 31 Aug 2020 15:29:34 +0200	[thread overview]
Message-ID: <87pn77c5a9.fsf@gnu.org> (raw)
In-Reply-To: <20200704182548.25280-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Sat, 4 Jul 2020 23:55:48 +0530")

Hi Arun,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> This patchset fixes a bug in the launchpad importer, and improves it to
> recognize more URLs and extensions. `guix refresh --list-updaters` reports an
> improvement in coverage from 0.1% to 0.2%.

All three patches LGTM, thank you!

> On a side note, all our updaters try to detect the URL format through a series
> of guesses. But, all our packages already encode information about how to
> construct the source URL from the version. If we could somehow tap into that
> information, our updaters would be much simpler. Unfortunately, all the uri
> fields of packages are strings. We would need them to be functions that take
> the version as an argument. This is a major conversion. Is it feasible? Any
> better ideas?

I sympathize with the idea, but I think it’s a bit too ambitious.  All
in all, what we currently have seems like a reasonable tradeoff.

Ludo’.




  parent reply	other threads:[~2020-08-31 13:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-04 18:25 [bug#42192] [PATCH 0/3] Improve launchpad updater Arun Isaac
2020-07-04 18:33 ` [bug#42192] [PATCH 1/3] import: launchpad: Handle list of source URLs correctly Arun Isaac
2020-07-04 18:33   ` [bug#42192] [PATCH 2/3] import: launchpad: Recognize the .orig.tar.gz extension Arun Isaac
2020-07-04 18:33   ` [bug#42192] [PATCH 3/3] import: launchpad: Recognize more URLs Arun Isaac
2020-08-31 13:29 ` Ludovic Courtès [this message]
2020-09-01 17:20   ` bug#42192: [PATCH 0/3] Improve launchpad updater Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn77c5a9.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=42192@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.