all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
Cc: 44193@debbugs.gnu.org
Subject: [bug#44193] [PATCH 0/1] 'guix publish --cache' can publish items not yet cached
Date: Sun, 25 Oct 2020 17:49:38 +0100	[thread overview]
Message-ID: <87pn56dzdp.fsf@gnu.org> (raw)
In-Reply-To: <87v9ey5u2e.fsf@gmail.com> ("Miguel Ángel Arruga Vivas"'s message of "Sun, 25 Oct 2020 14:11:37 +0100")

Hi!

Miguel Ángel Arruga Vivas <rosen644835@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>> Thus, the first narinfo request for an item would always return 404;
>> one would have to wait until the item is baked to get 200 and download
>> the substitute.
>
> I'd argue that returning unconditionally the 404 is a problem.  If the
> nar is getting baked, I guess that a 202[1] would be the appropriate
> answer, and I'd leave the 404 for invalid store paths[2].  This way the
> client could implement more policies: the classic timeout, but also, for
> example, it might check other servers before checking once again if
> nobody else has it, or directly wait until a 404 is reached.  WDYT?

Indeed, 202 seems more appropriate (and it’s precisely half of 404, that
tells something!).

Unfortunately (guix scripts substitute) currently explicitly checks for
404 and 200 and considers anything else to be a transient error with a
default TTL (in ‘handle-narinfo-response’).  So we would need to adapt
that first and then wait until some time has passed before ‘guix
publish’ can return 202.  :-/

I guess we can change (guix scripts substitute) with that in mind
already.  WDYT?

Ludo’.




  reply	other threads:[~2020-10-25 16:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-24 14:49 [bug#44193] [PATCH 0/1] 'guix publish --cache' can publish items not yet cached Ludovic Courtès
2020-10-24 14:54 ` [bug#44193] [PATCH 1/1] publish: Add '--cache-bypass-threshold' Ludovic Courtès
2020-10-28 15:26   ` bug#44193: " Ludovic Courtès
2020-10-25 13:11 ` [bug#44193] [PATCH 0/1] 'guix publish --cache' can publish items not yet cached Miguel Ángel Arruga Vivas
2020-10-25 16:49   ` Ludovic Courtès [this message]
2020-10-25 17:30     ` Miguel Ángel Arruga Vivas
2020-10-26 10:50       ` Ludovic Courtès
2020-10-27 19:19         ` Miguel Ángel Arruga Vivas
2020-10-28  9:39           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn56dzdp.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=44193@debbugs.gnu.org \
    --cc=rosen644835@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.