From: Xinglu Chen <public@yoctocell.xyz>
To: Attila Lendvai <attila@lendvai.name>, 50750@debbugs.gnu.org
Cc: Attila Lendvai <attila@lendvai.name>
Subject: [bug#50750] [PATCH 1/2] gnu: Add trezor-gpg-pinentry-tk 0.0.10.
Date: Fri, 24 Sep 2021 15:49:25 +0200 [thread overview]
Message-ID: <87pmsyjd7e.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20210923080914.6149-1-attila@lendvai.name>
[-- Attachment #1: Type: text/plain, Size: 2183 bytes --]
On Thu, Sep 23 2021, Attila Lendvai wrote:
> * gnu/packages/finance.scm (trezor-gpg-pinentry-tk): New variable.
> ---
> gnu/packages/finance.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index 4aaab58906..9b073541de 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -884,6 +884,31 @@ the Monero GUI client.")
> Ledger Nano as a hardware SSH/GPG agent.")
> (license license:lgpl3)))
>
> +(define-public trezor-gpg-pinentry-tk
> + (package
> + (name "trezor-gpg-pinentry-tk")
> + (version "0.0.10")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/rendaw/trezor-gpg-pinentry-tk/")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1mblx4favmw4nf7k9rfl00ivv77kgdiwghyz4xv5cp0v410kjaqc"))))
> + (build-system python-build-system)
> + (propagated-inputs
> + `(("python-tkinter" ,python "tk")))
> + (home-page "https://github.com/rendaw/trezor-gpg-pinentry-tk")
> + (synopsis "A GPG PIN entry program for use with trezor-agent
> +or for people with number-only PINs.")
The synopsis starts with an article, and it is a bit long (see “16.4.4
Synopses and Descriptions” in the manual for more details), I suggest
GPG pinentry program for use with @code{trezor-agent}
> + (description
> + "An alternate PIN entry for use with trezor-agent, or for people
> +with number-only PINs. It displays a grid of unlabeled buttons and
> +supports configurable keyboard mappings.")
The first sentence lacks a subject, and there should be two spaces after
a period. I suggest
This package provides a GPG pinentry program for use with
@code{trezor-agent}, or for people with number-only PINs. It displays
a grid of unlabeled buttons and supports configurable keyboard
settings.
> + (license license:lgpl3)))
The ‘license.txt’ file says BSD-2.
Could you send an updated patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-09-24 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 8:09 [bug#50750] [PATCH 1/2] gnu: Add trezor-gpg-pinentry-tk 0.0.10 Attila Lendvai
2021-09-23 8:27 ` Attila Lendvai
2021-09-24 13:49 ` Xinglu Chen [this message]
2021-09-25 16:08 ` [bug#50750] [PATCH] " Attila Lendvai
2021-09-26 9:23 ` Xinglu Chen
2021-10-04 8:42 ` bug#50750: " Efraim Flashner
2021-09-28 0:40 ` [bug#50750] [PATCH 1/4] tests: Smarten up git repository testing framework Attila Lendvai
2021-09-28 0:40 ` [bug#50750] [PATCH 2/4] tests: Move keys into ./tests/keys/ and add a third ed25519 key Attila Lendvai
2021-09-28 0:40 ` [bug#50750] [PATCH 3/4] tests: Add failing test for .guix-authorizations and channel intro Attila Lendvai
2021-09-28 0:40 ` [bug#50750] [PATCH 4/4] guix: git-authenticate: Fix authenticate-repository Attila Lendvai
2021-09-28 0:47 ` [bug#50750] (No Subject) Attila Lendvai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmsyjd7e.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=50750@debbugs.gnu.org \
--cc=attila@lendvai.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.