all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 50657@debbugs.gnu.org
Cc: public@yoctocell.xyz, phodina@protonmail.com
Subject: [bug#50657] [PATCH v2] gnu: Add vpn-slice.
Date: Sun, 05 Dec 2021 12:14:22 +0100	[thread overview]
Message-ID: <87pmqbl2wh.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <aYDmel23x5oNh6gRBLyPkVFB2bWi-Majf_BM80ce6eg4ilIZpNs4vpLe8vaEX933-z6fbN0KbGNDBGjCDP2OsowqBHSdXRNXBeJaPIiAyvk=@protonmail.com> (phodina via Guix-patches via's message of "Mon, 27 Sep 2021 22:32:45 +0000")

Hello,

phodina via Guix-patches via <guix-patches@gnu.org> writes:

> I checked the /etc/hosts and seems that on Guix System there aren't symlink to the /gnu/store.
>
> $ readlink -f /etc/hostname
> /etc/hostname

But it is read-only, isn't it? If so, how can the program do its stuff,
since it is supposed to modify the file?

> +        (sha256
> +          (base32
> +            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))

Nitpick: Hash string should be on the same line as base32

> +    (description "This package allows you to minimize your contact with
> +an intrusive VPN --- split your traffic between the VPN tunnel and your normal
> +network interfaces")

Nitpick: I think English does not add spaces between "---".

> +    (license license:gpl3)))

You forgot to change the license, as suggested by Xinglu Chen.

Regards,
-- 
Nicolas Goaziou




  parent reply	other threads:[~2021-12-05 11:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18 10:23 [bug#50657] [PATCH] gnu: Add vpn-slice phodina via Guix-patches via
2021-09-20 12:37 ` Xinglu Chen
2021-09-27 22:32 ` [bug#50657] [PATCH v2] " phodina via Guix-patches via
2021-12-03 15:35   ` phodina via Guix-patches via
2021-12-05 11:14   ` Nicolas Goaziou [this message]
2021-11-01 14:04 ` [bug#50657] [PATCH] " Allan Adair
2023-09-01 20:38 ` bug#50657: " Vagrant Cascadian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmqbl2wh.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=50657@debbugs.gnu.org \
    --cc=phodina@protonmail.com \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.