From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>, 58017@debbugs.gnu.org
Cc: "Attila Lendvai" <attila@lendvai.name>,
57978@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#58017] bug#57978: [PATCH 2/2] substitute: Retry downloading when a nar is unavailable.
Date: Fri, 23 Sep 2022 10:17:16 +0200 [thread overview]
Message-ID: <87pmfmcxo3.fsf@gmail.com> (raw)
In-Reply-To: <20220923061957.5658-2-ludo@gnu.org>
Hi,
On ven., 23 sept. 2022 at 08:19, Ludovic Courtès <ludo@gnu.org> wrote:
> Fixes <https://issues.guix.gnu.org/57978>
> Reported by Attila Lendvai <attila@lendvai.name>.
>
> Previously, if a narinfo was available but its corresponding nar was
> missing (for instance because the narinfo was cached and the server
> became unreachable in the meantime), 'guix substitute --substitute'
> would try to download the nar from its preferred location and abort when
> that fails. This change forces one retry with each of the URLs.
>
> * guix/scripts/substitute.scm (download-nar): Do not catch
> 'http-get-error?' exceptions.
> (system-error?, network-error?, process-substitution/fallback): New
> procedures.
> (process-substitution): Call 'process-substitution/fallback' upon
> 'network-error?'.
> * tests/substitute.scm ("substitute, first URL has narinfo but lacks nar, second URL unauthorized")
> ("substitute, first URL has narinfo but nar is 404, both URLs authorized")
> ("substitute, first URL has narinfo but nar is 404, one URL authorized")
> ("substitute, narinfo is available but nar is missing"): New tests.
LGTM.
> +(test-equal "substitute, first URL has narinfo but nar is 404, one URL authorized"
> + "Substitutable data."
> + (with-narinfo*
> + (string-append %narinfo "Signature: "
> + (signature-field
> + %narinfo
> + #:public-key %wrong-public-key))
> + %main-substitute-directory
> +
> + (with-http-server `((200 ,(string-append %narinfo "Signature: "
> + (signature-field
> + %narinfo
> + #:public-key %wrong-public-key)))
> + (404 "Sorry, nar is missing!"))
> + (let ((url1 (%local-url)))
> + (parameterize ((%http-server-port 0))
> + (with-http-server `((200 ,(string-append %narinfo "Signature: "
> + (signature-field %narinfo)))
> + (404 "Sorry, nar is missing!"))
> + (let ((url2 (%local-url)))
> + (dynamic-wind
> + (const #t)
> + (lambda ()
> + (parameterize ((substitute-urls
> + (list url1 url2
> + (string-append "file://"
> + %main-substitute-directory))))
> + (request-substitution (string-append (%store-prefix)
> + "/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-foo")
> + "substitute-retrieved"))
> + (call-with-input-file "substitute-retrieved" get-string-all))
> + (lambda ()
> + (false-if-exception (delete-file "substitute-retrieved")))))))))))
Although I do not understand this test. Why is 404 appearing twice?
Cheers,
simon
next prev parent reply other threads:[~2022-09-23 9:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 13:11 bug#57978: the fallback machanism for substitute servers doesn't work? Attila Lendvai
2022-09-21 20:43 ` zimoun
2022-09-22 9:47 ` Ludovic Courtès
2022-09-23 6:16 ` bug#57978: [PATCH 0/2] Retry nar downloads upon failure Ludovic Courtès
2022-09-28 21:24 ` bug#57978: bug#58017: " Ludovic Courtès
2022-09-23 6:19 ` bug#57978: [PATCH 1/2] substitute: Split nar download Ludovic Courtès
2022-09-23 6:19 ` bug#57978: [PATCH 2/2] substitute: Retry downloading when a nar is unavailable Ludovic Courtès
2022-09-23 8:17 ` zimoun [this message]
2022-09-24 16:20 ` [bug#58017] " Ludovic Courtès
2022-09-24 1:57 ` bug#57978: [bug#58017] " Maxime Devos
2022-09-24 16:22 ` Ludovic Courtès
2022-09-24 17:18 ` bug#57978: " Maxime Devos
2022-09-23 7:56 ` bug#57978: [PATCH 1/2] substitute: Split nar download zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmfmcxo3.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=57978@debbugs.gnu.org \
--cc=58017@debbugs.gnu.org \
--cc=attila@lendvai.name \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.