all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Felix Lechner <felix.lechner@lease-up.com>
Cc: Sergey Trofimov <sarg@sarg.org.ru>, 62156-done@debbugs.gnu.org
Subject: bug#62156: [PATCH 0/1] gnu: Add atftp.
Date: Mon, 27 Mar 2023 18:49:19 +0200	[thread overview]
Message-ID: <87pm8uf8c0.fsf_-_@gnu.org> (raw)
In-Reply-To: <b423186f49dfdfff336d4ff8058fe7190c132a73.1679372740.git.felix.lechner@lease-up.com> (Felix Lechner's message of "Mon, 20 Mar 2023 21:25:40 -0700")

Hi,

Felix Lechner <felix.lechner@lease-up.com> skribis:

> * gnu/packages/networking.scm (atftp): New variable.
>
> Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
> reviews of this item!

I tweaked the description (to start with a full sentence) and passed it
through ‘guix style’.

> For the atftp package added in the preceeding commit, lint produced this
> warning:
>
>   gnu/packages/networking.scm:2924:5: atftp@0.8.0:
>     URI https://git.code.sf.net/p/atftp/code not reachable:
>       404 ("Not Found")
>
> Thanks to Sergey Trofimov for suggesting a fix! [1]
>
>   [1]  https://issues.guix.gnu.org/62156#3
>
> It was implemented here, and the warning disappeared.
>
> * guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.
>
> Co-authored-by: Sergey Trofimov <sarg@sarg.org.ru>

Nice.  I adjusted ‘tests/lint.scm’ accordingly.

Applied both; thank you, and thanks to the reviewers!

Ludo’.




      parent reply	other threads:[~2023-03-27 16:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13  4:41 [bug#62156] [PATCH 0/1] gnu: Add atftp Felix Lechner via Guix-patches via
2023-03-13  4:42 ` [bug#62156] [PATCH 1/1] " Felix Lechner via Guix-patches via
2023-03-19 23:03 ` [bug#62156] [PATCH v2] " Felix Lechner via Guix-patches via
2023-03-20  7:34 ` Sergey Trofimov
2023-03-20 16:57 ` [bug#62156] [PATCH v3 1/2] " Felix Lechner via Guix-patches via
2023-03-20 16:57   ` [bug#62156] [PATCH v3 2/2] lint: Append "/info/refs" to git-reference-url Felix Lechner via Guix-patches via
2023-03-21  4:25 ` [bug#62156] [PATCH v4 1/2] gnu: Add atftp Felix Lechner via Guix-patches via
2023-03-21  4:25   ` [bug#62156] [PATCH v4 2/2] lint: Append "/info/refs" to git-reference-url Felix Lechner via Guix-patches via
2023-03-27 16:49   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm8uf8c0.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=62156-done@debbugs.gnu.org \
    --cc=felix.lechner@lease-up.com \
    --cc=sarg@sarg.org.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.