From: Mathieu Othacehe <othacehe@gnu.org>
To: peter@polidoro.io
Cc: Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
67905@debbugs.gnu.org,
Liliana Marie Prikler <liliana.prikler@gmail.com>,
Andrew Tropin <andrew@trop.in>
Subject: [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
Date: Mon, 25 Dec 2023 17:40:07 +0100 [thread overview]
Message-ID: <87plyui6c8.fsf@gnu.org> (raw)
In-Reply-To: <88b10c5b72478385da5d57218139845e93f48da0.1702995554.git.peter@polidoro.io> (peter@polidoro.io's message of "Tue, 19 Dec 2023 09:19:42 -0500")
Hello,
There are two linter warnings here:
--8<---------------cut here---------------start------------->8---
/home/mathieu/guix/gnu/packages/emacs-xyz.scm:1382:5:
emacs-golden-ratio@20230912.1825: the source file name should contain
the package name
/home/mathieu/guix/gnu/packages/emacs-xyz.scm:1382:5:
emacs-golden-ratio@20230912.1825: permanent redirect from
https://github.com/roman/golden-ratio.el.git to
https://github.com/roman/golden-ratio.el
--8<---------------cut here---------------end--------------->8---
> + (uri (git-reference
> + (url "https://github.com/roman/golden-ratio.el.git")
> + (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))
The first one can probably be resolved by adding the following line
here:
(file-name (git-file-name name version))
> + (sha256
> + (base32 "0a635a3h6jx0clgwmhwc48i14y3xy5q29y37lp2sjnbxx1hlmkli"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/roman/golden-ratio.el")
And the second one by updating this URL.
Could you please send an updated patch?
Thanks,
Mathieu
next prev parent reply other threads:[~2023-12-25 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 14:19 [bug#67905] [PATCH] gnu: Add emacs-golden-ratio peter
2023-12-25 16:40 ` Mathieu Othacehe [this message]
2024-01-03 19:48 ` peter
2024-01-04 10:28 ` Nicolas Goaziou via Guix-patches via
2024-01-04 14:16 ` peter
2024-01-21 23:29 ` bug#67905: " Nicolas Goaziou via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plyui6c8.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=67905@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=cox.katherine.e+guix@gmail.com \
--cc=liliana.prikler@gmail.com \
--cc=peter@polidoro.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.