From: Kei Kebreau <kkebreau@posteo.net>
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31733@debbugs.gnu.org
Subject: [bug#31733] [PATCH] gnu: encfs: Update to 1.9.5.
Date: Thu, 14 Jun 2018 10:53:49 -0400 [thread overview]
Message-ID: <87o9gd2zcy.fsf@posteo.net> (raw)
In-Reply-To: <20180606094730.15892-1-ambrevar@gmail.com> (Pierre Neidhardt's message of "Wed, 6 Jun 2018 11:47:30 +0200")
[-- Attachment #1: Type: text/plain, Size: 1814 bytes --]
Hi Pierre,
> * gnu/packages/crypto.scm (encfs): Update to 1.9.5.
Don't forget to mention the new 'make-unittests' phase!
> ---
> gnu/packages/crypto.scm | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
> index f96fe0490..4707355f3 100644
> --- a/gnu/packages/crypto.scm
> +++ b/gnu/packages/crypto.scm
> @@ -216,7 +216,7 @@ communication.")
> (define-public encfs
> (package
> (name "encfs")
> - (version "1.9.1")
> + (version "1.9.5")
> (source
> (origin
> (method url-fetch)
> @@ -225,7 +225,7 @@ communication.")
> version "/encfs-" version ".tar.gz"))
> (sha256
> (base32
> - "1906254dg5hwljh0h4gyrw09ms3b57dlhjfzhfzffv50yzpkl837"))
> + "0qzxavvv20577bxvly8s7d3y7bqasqclc2mllp0ddfncjm9z02a7"))
> (modules '((guix build utils)))
> ;; Remove bundled dependencies in favour of proper inputs.
> (snippet '(for-each delete-file-recursively
> @@ -244,7 +244,12 @@ communication.")
> ("openssl" ,openssl)
> ("tinyxml2" ,tinyxml2)))
> (arguments
> - `(#:configure-flags (list "-DUSE_INTERNAL_TINYXML=OFF")))
> + `(#:configure-flags (list "-DUSE_INTERNAL_TINYXML=OFF")
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'check 'make-unittests
> + (lambda _
> + (zero? (system* "make" "unittests")))))))
Any particular reason you decided to use '(zero? (system* ...))' rather
than '(invoke ...)' for this phase? I tried it with 'invoke' and it
worked fine.
> (home-page "https://vgough.github.io/encfs")
> (synopsis "Encrypted virtual file system")
> (description
Other than the above, this patch looks good! :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-06-14 14:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 9:47 [bug#31733] [PATCH] gnu: encfs: Update to 1.9.5 Pierre Neidhardt
2018-06-14 14:53 ` Kei Kebreau [this message]
2018-06-14 15:04 ` Kei Kebreau
2018-06-16 14:04 ` Pierre Neidhardt
2018-06-16 15:23 ` Kei Kebreau
2018-06-16 15:44 ` Pierre Neidhardt
2018-06-16 20:35 ` Kei Kebreau
2018-06-17 17:11 ` Pierre Neidhardt
2018-06-18 2:01 ` bug#31733: " Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9gd2zcy.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=31733@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.