From: Gabriel Hondet <gabrielhondet@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33920@debbugs.gnu.org
Subject: [bug#33920] [PATCH] gnu: Add gauche.
Date: Sat, 12 Jan 2019 11:25:26 +0100 [thread overview]
Message-ID: <87o98m8961.fsf@gmail.com> (raw)
In-Reply-To: <87sgy14yg2.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2150 bytes --]
Hi Ludovic,
On Wed 09 Jan 2019 at 16:56 Ludovic Courtès wrote:
> As swedebugia noted, Gauche uses libgc and libatomic-ops. Could you
> try to add these two libraries as inputs and to adjust the package to
> make sure it does not use the bundled copies?
Sure I'll work on it.
>> +(define-public gauche
>> + (package
>> + (name "gauche")
>> + (version "0.9.7")
>> + (home-page "http://practical-scheme.net/gauche/index.html")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "http://prdownloads.sourceforge.net/gauche/Gauche-"
>> + version ".tgz"))
>
> Please use mirror://sourceforge here.
As far as I understand, I should use
"mirror://sourceforge/gauche/Gauche-"
but it does not work (redirections fail with a 404 not found error).
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'patch-/bin/sh
>> + ;; needed only for tests
>> + (lambda _
>> + (begin
>> + (setenv "CONFIG_SHELL" (which "sh"))
>> + (substitute* '("configure"
>> + "test/www.scm"
>> + "config.guess"
>> + "ltmain.sh"
>> + "ext/tls/test.scm"
>> + "gc/configure"
>> + "lib/gauche/configure.scm"
>> + "lib/gauche/package/util.scm"
>> + "lib/gauche/process.scm")
>> + (("/bin/sh") (which "sh")))
>
> This looks redundant with what the standard ‘patch-source-shebangs’ and
> ‘configure’ phases do, no?
Isn't 'patch-source-shebangs' only patching the shebangs? Because here
I have to patch other path specifications in the source as well. On the
other hand, for the 'setenv', you are totally right.
> Out of curiosity, do these tests rely on specific host name lookups or
> external services?
I'll look at it.
Thank you for these useful and essential tips,
Gabriel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-01-12 10:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 7:47 [bug#33920] [PATCH] gnu: Add gauche Gabriel Hondet
2019-01-04 22:36 ` swedebugia
2019-01-05 8:32 ` Gabriel Hondet
2019-01-09 15:56 ` Ludovic Courtès
2019-01-12 10:25 ` Gabriel Hondet [this message]
2019-01-13 20:40 ` Ludovic Courtès
2019-01-15 8:11 ` Gabriel Hondet
2019-01-15 17:34 ` bug#33920: " Ludovic Courtès
2019-01-16 8:49 ` [bug#33920] [PATCH] gnu: gauche: Update to 0.9.7 - removed html doc Gabriel Hondet
2019-01-16 10:41 ` Gabriel Hondet
2019-01-16 17:32 ` Pierre Neidhardt
2019-01-16 19:31 ` Gabriel Hondet
2019-01-17 7:29 ` Pierre Neidhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o98m8961.fsf@gmail.com \
--to=gabrielhondet@gmail.com \
--cc=33920@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.