all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 39729@debbugs.gnu.org
Subject: [bug#39729] [PATCH 0/7] Testing the graphical installer
Date: Thu, 05 Mar 2020 23:46:27 +0100	[thread overview]
Message-ID: <87o8ta5sjg.fsf@gnu.org> (raw)
In-Reply-To: <87mu946mf1.fsf@gmail.com> (Mathieu Othacehe's message of "Thu, 27 Feb 2020 17:10:42 +0100")

Hi Mathieu!

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

>> The second part implements the actual test.  The new (gnu installer
>> tests) module provides tools to implement a dialogue with the installer,
>> and the new “gui-installed-os” test uses it to perform a bare-bones
>> style installation.  There’s a commented out variant that does it on
>> an encrypted root, but it currently fails presumably due to
>> <https://issues.guix.gnu.org/issue/39712>.
>>
>> That’s it!
>>
>> Feedback welcome!
>
> This serie LGTM, this is really impressive :) About the umounting issue,
> you were right. Umounting failed for both %test-gui-installed-os and
> %test-gui-installed-os-encrypted.
>
> The issue was that guix-daemon was keeping open files inside the
> cow-store, preventing the umount. I discovered then a second issue, some
> udevd workers, started while the cow-store was active were also
> preventing the umounting.
>
> I published a few patches on top of yours on wip-installer-test to fix
> those issues.

Well done, woohoo!

I’ve pushed the whole series on ‘master’, including your bug fixes.

We can think about writing installer tests for other configurations
now.  That should be the easy part.  :-)

> PS: I had a hard time debugging the marionette, couldn't find better to
> add some syslog, wait an hour to test & repeat. Do you have a better
> approach? Would it be possible to have a debug ssh in the marionette?

I don’t really have a better approach.  If you want to see the output of
‘guix system init’, you can redirect its stderr to /dev/console (wrap
the ‘invoke’ call in ‘with-error-to-file’), and then you get a better
idea of what’s going on.  But that’s about it.

SSH wouldn’t be very helpful because the test process is non-interactive.

Thanks!

Ludo’.

      reply	other threads:[~2020-03-05 22:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21 23:16 [bug#39729] [PATCH 0/7] Testing the graphical installer Ludovic Courtès
2020-02-21 23:20 ` [bug#39729] [PATCH 1/7] tests: 'run-basic-test' can enter a root password Ludovic Courtès
2020-02-21 23:20   ` [bug#39729] [PATCH 2/7] installer: Use a Guile-Newt snapshot that supports 'form-watch-fd' Ludovic Courtès
2020-02-21 23:20   ` [bug#39729] [PATCH 3/7] installer: Implement a dialog on /var/guix/installer-socket Ludovic Courtès
2020-02-21 23:20   ` [bug#39729] [PATCH 4/7] installer: Bypass connectivity check when /tmp/installer-assume-online exists Ludovic Courtès
2020-02-21 23:20   ` [bug#39729] [PATCH 5/7] installer: Run commands without hopping through the shell Ludovic Courtès
2020-02-21 23:20   ` [bug#39729] [PATCH 6/7] installer: Honor /tmp/installer-system-init-options Ludovic Courtès
2020-02-21 23:20   ` [bug#39729] [PATCH 7/7] tests: install: Add "gui-installed-os" Ludovic Courtès
2020-02-27 16:10 ` [bug#39729] [PATCH 0/7] Testing the graphical installer Mathieu Othacehe
2020-03-05 22:46   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8ta5sjg.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=39729@debbugs.gnu.org \
    --cc=m.othacehe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.