From: Joshua Branson via Guix-patches via <guix-patches@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
Cc: 58652@debbugs.gnu.org, Zain Jabbar <zaijab2000@gmail.com>
Subject: [bug#58652] Creating home-emacs-service-type
Date: Fri, 21 Oct 2022 11:42:23 -0400 [thread overview]
Message-ID: <87o7u55gkg.fsf@dismail.de> (raw)
In-Reply-To: <77fbe7e648edfc15c8007616199a867dbae72b71.camel@ist.tugraz.at> (Liliana Marie Prikler's message of "Fri, 21 Oct 2022 08:05:53 +0200")
Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> writes:
> Am Donnerstag, dem 20.10.2022 um 11:30 -1000 schrieb Zain Jabbar:
>> Aloha All,
>>
>> Thank you for your input.
>>
>> > Note that you reverted the patch direction.
>>
>> Please forgive me for that. Is it possible to explain what I did
>> wrong? I will outline my steps to help you figure out what I did
>> incorrectly.
>>
>> 1. I cloned the repo
>> 2. Used =guix shell -D guix=
>> 3. Ran =./bootstrap=
>> 4. Ran =./configure --localstatedir=/var=
>> 5. Ran =make && make check=. By the way, my =make check= had a failed
>> test, I don't know if that was expected.
>> 6. Made some commits
>> 7. I used =git diff HEAD origin/HEAD > my-guix-patch.patch=.
>>
>> I might have messed around too much in my cloned repo, throwing
>> something off.
> Instead of 6+7, write a single commit and use =git format-patch=.
>
> You can of course do multi-patch series, but this feature seems not to
> be one that requires that. Always clean up your commit log after a
> hacking session ;)
I personally find it really easy to use git send-email. :)
Assuming you are in the guix git directory, then this command will send
the latest commit as a patch to the guix-patches email list.
#+BEGIN_SRC sh
git send-email --to='guix-patches@gnu.org' \
--cc='efraim@flashner.co.il' \
--subject-prefix='Patch staging ' --annotate HEAD^
#+END_SRC
This website will walk you through setting up git send email.
https://git-send-email.io/
next prev parent reply other threads:[~2022-10-21 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 1:59 [bug#58652] Creating home-emacs-service-type Zain Jabbar
2022-10-20 12:53 ` Liliana Marie Prikler
2022-10-20 21:30 ` Zain Jabbar
2022-10-21 6:05 ` Liliana Marie Prikler
2022-10-21 15:42 ` Joshua Branson via Guix-patches via [this message]
2022-10-22 7:09 ` Zain Jabbar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7u55gkg.fsf@dismail.de \
--to=guix-patches@gnu.org \
--cc=58652@debbugs.gnu.org \
--cc=jbranso@dismail.de \
--cc=liliana.prikler@ist.tugraz.at \
--cc=zaijab2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.