From: "Ludovic Courtès" <ludo@gnu.org>
To: Christina O'Donnell <cdo@mutix.org>
Cc: Maxime Devos <maximedevos@telnet.be>,
Steve George <steve@futrile.net>,
56576-done@debbugs.gnu.org
Subject: bug#56576: [PATCH v3 1/3] gnu: Add markdeep.
Date: Thu, 11 Apr 2024 12:37:46 +0200 [thread overview]
Message-ID: <87o7aggp6t.fsf@gnu.org> (raw)
In-Reply-To: <aa7483564f086c1dd70c428c0156ef8355e76a61.1712184392.git.cdo@mutix.org> (Christina O'Donnell's message of "Wed, 3 Apr 2024 23:46:32 +0100")
Hi Christina,
Christina O'Donnell <cdo@mutix.org> skribis:
> * gnu packages/documentation.scm (markdeep): New variable.
>
> Change-Id: I34303377f50740ba357c1bb299c9434079a6e23d
> ---
> gnu/packages/documentation.scm | 65 ++++++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
>
> Hi,
>
> I've gone through these patches, making the changes that Maxime listed
> and that came up from `guix lint`. I've added the additional package
> markdeep, which is a css/javascript rendering library needed for stddoc.
>
> I checked these very carefully, but I'm new to this so it's likely that
> I've made at least a few mistakes. Everything appears to be working as
> far as I've tested it. I had anything to test nuklear with, so I'm
> taking that part on faith.
>
> Let me know whether there's anything that I could change or do better
> for next time.
It’s perfect! There was a tiny indentation issue for phases in
‘markdeep’ but the rest looks good to me.
Applied, thanks!
Ludo’.
prev parent reply other threads:[~2024-04-11 10:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 14:57 [bug#56576] [PATCH] gnu: Add nuklear Antero Mejr via Guix-patches via
2022-08-05 3:03 ` 宋文武 via Guix-patches via
2022-08-06 22:57 ` [bug#56576] [PATCH 1/2] gnu: Add stddoc Antero Mejr via Guix-patches via
2022-08-06 22:57 ` [bug#56576] [PATCH 2/2] gnu: Add nuklear Antero Mejr via Guix-patches via
2022-08-07 12:10 ` [bug#56576] [PATCH 1/2] gnu: Add stddoc Maxime Devos
2024-04-03 22:46 ` [bug#56576] [PATCH v3 1/3] gnu: Add markdeep Christina O'Donnell
2024-04-03 22:46 ` [bug#56576] [PATCH v3 2/3] gnu: Add stddoc Christina O'Donnell
2024-04-03 22:46 ` [bug#56576] [PATCH v3 3/3] gnu: Add nuklear Christina O'Donnell
2024-04-11 10:37 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7aggp6t.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=56576-done@debbugs.gnu.org \
--cc=cdo@mutix.org \
--cc=maximedevos@telnet.be \
--cc=steve@futrile.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.