From: ludo@gnu.org (Ludovic Courtès)
To: Meiyo Peng <meiyo.peng@gmail.com>
Cc: 33058-done@debbugs.gnu.org
Subject: bug#33058: [PATCH] gnu: Add i3blocks.
Date: Fri, 19 Oct 2018 22:45:47 +0200 [thread overview]
Message-ID: <87mur9ekck.fsf@gnu.org> (raw)
In-Reply-To: <87pnwa8eow.fsf@gmail.com> (Meiyo Peng's message of "Tue, 16 Oct 2018 16:43:11 +0800")
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
Hi Meiyo,
Meiyo Peng <meiyo.peng@gmail.com> skribis:
> I created a package for i3blocks. This is my first guix package, so
> forgive me if i did anything wrong.
It looks great to me!
>>From 6116bec4d60175e2d1fb12da75c803962ddb3ec7 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng@gmail.com>
> Date: Tue, 16 Oct 2018 15:16:43 +0800
> Subject: [PATCH] gnu: Add i3blocks.
>
> * gnu/packages/wm.scm (i3blocks): New variable.
I’ve applied it with the minor changes below: leave the default value of
#:tests? (it doesn’t hurt), and return #t in the build phase. That’s
#it!
Thank you for the patch, and welcome! :-)
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 666 bytes --]
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index d5e191770..68d497e95 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -260,8 +260,8 @@ developers.")
(lambda* (#:key outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
(man1 (string-append out "/share/man/man1")))
- (install-file "docs/i3blocks.1" man1)))))
- #:tests? #f))
+ (install-file "docs/i3blocks.1" man1)
+ #t))))))
(native-inputs
`(("autoconf" ,autoconf)
("automake" ,automake)
next prev parent reply other threads:[~2018-10-19 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 8:43 [bug#33058] [PATCH] gnu: Add i3blocks Meiyo Peng
2018-10-19 20:45 ` Ludovic Courtès [this message]
2018-10-20 2:27 ` Meiyo Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mur9ekck.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33058-done@debbugs.gnu.org \
--cc=meiyo.peng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.