From: Kei Kebreau <kkebreau@posteo.net>
To: Alex Vong <alexvong1995@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Octave & QtOctave
Date: Sat, 08 Dec 2018 13:23:43 -0500 [thread overview]
Message-ID: <87mupfx4gg.fsf@posteo.net> (raw)
In-Reply-To: <87tvjpwd09.fsf@posteo.net> (Kei Kebreau's message of "Fri, 07 Dec 2018 10:52:06 -0500")
[-- Attachment #1: Type: text/plain, Size: 3748 bytes --]
Kei Kebreau <kkebreau@posteo.net> writes:
> Alex Vong <alexvong1995@gmail.com> writes:
>
>> Kei Kebreau <kkebreau@posteo.net> writes:
>>
>>> Alex Vong <alexvong1995@gmail.com> writes:
>>>
>>>> Kei Kebreau <kkebreau@posteo.net> writes:
>>>>
>>>>> Alex Vong <alexvong1995@gmail.com> writes:
>>>>>
>>>>>> Hello Kei,
>>>>>>
>>>>>> Kei Kebreau <kkebreau@posteo.net> writes:
>>>>>>
>>>>>> [...]
>>>>>>>
>>>>>>> Here are two tentative patches that make the changes we've discussed.
>>>>>>> Also, should we make a deprecated-package definition for qtoctave?
>>>>>>
>>>>>> I think some additional changes related to "(assoc-ref inputs ..."
>>>>>> needed to be made. Otherwise, looks good to me! Here is a patch I made
>>>>>> earlier but it was not tested, feel free to cherry-pick what is needed:
>>>>>>
>>>>>> From 2b04caa66c17da257dfb4f4ccb94e8d629b95e53 Mon Sep 17 00:00:00 2001
>>>>>> From: Alex Vong <alexvong1995@gmail.com>
>>>>>> Date: Mon, 3 Dec 2018 03:39:40 +0800
>>>>>> Subject: [PATCH] gnu: Rename "octave" to "octave-cli" and "qtoctave" to
>>>>>> "octave".
>>>>>>
>>>>>> * gnu/packages/maths.scm (octave): Rename to octave-cli.
>>>>>> [name]: Change to "octave-cli".
>>>>>> (qtoctave): Rename to octave.
>>>>>> [name]: Change to "octave".
>>>>>> [inherit]: Inherit from octave-cli.
>>>>>> [source]: Likewise.
>>>>>> [inputs]: Likewise.
>>>>>> [native-inputs]: Likewise.
>>>>>> [arguments]: Likewise.
>>>>>> (flann): Update accordingly.
>>>>>> * gnu/packages/engineering.scm (qucs): Likewise.
>>>>>> (qucs-s): Likewise.
>>>>>> * gnu/packages/machine-learning.scm (shogun): Likewise.
>>>>>
>>>>> ...
>>>>>
>>>>>> - ("octave" ,octave)
>>>>>> + ("octave-cli" ,octave-cli)
>>>>>
>>>>> I see the main difference is that you've replace the package's
>>>>> associated string to "octave-cli" as well as the name, whereas I've only
>>>>> replaced the package name. Should I replace the associated package
>>>>> string, too?
>>>>
>>>> According to the manual "6.7.2 Package Naming", the associated string is
>>>> used for package management commands such as 'guix package' and 'guix
>>>> build'. Therefore, I think we should change them as well, so that the
>>>> users can install the packages using the command
>>>> "guix package -i octave-cli" and "guix package -i octave"
>>>> respectively. What do you think?
>>>
>>> Maybe this is true when manipulating the package definition, but that
>>> doesn't seem to be the case in general. When I run
>>> "./pre-inst-env guix package --show=shogun", for example,
>>> "octave-cli@4.4.1" is listed as a dependency, even though "octave" is
>>> the associated name in shogun's input list.
>>>
>>> To be clear, I've changed the string for octave's and octave-cli's
>>> package name in their respective package definitions, but I haven't
>>> changed the string in the input lists of octave-cli's dependent
>>> packages.
>>>
>>> I'm inclined to follow convention when it comes to this, and other
>>> packages in input lists seem to omit extensions to the base name of the
>>> package in their assoc-lists. For example, ("gettext", gettext-minimal)
>>> and ("python", python-minimal-wrapper) are common inputs for packages.
>>
>> I think you are right! This was a misunderstanding on my part. I thought
>> the association string in the input lists must be the same as the
>> package name, but appraently this is not the case.
>>
>> Take gettext-minimal as an example,
>> its variable name is 'gettext-minimal',
>> its package name is "gettext-minimal",
>> but its input name is "gettext".
>
> Precisely! Unless anyone else has concerns that should be brought to
> light, I'll be committing this within the next 2 days.
>
> Thank you to all involved so far.
I've pushed this to master. Thanks again!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2018-12-08 18:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 0:56 Octave & QtOctave Brett Gilio
2018-11-24 13:12 ` Alex Vong
2018-11-24 22:10 ` ng0
2018-11-25 14:12 ` Should we rename qtoctave to octave and octave to octave-cli? (was Re: Octave & QtOctave) Alex Vong
2018-11-25 15:49 ` Brett Gilio
2018-11-25 15:58 ` Octave & QtOctave Ludovic Courtès
2018-11-27 17:53 ` Kei Kebreau
2018-11-28 10:47 ` Ludovic Courtès
2018-11-29 16:21 ` swedebugia
2018-12-02 19:25 ` Kei Kebreau
2018-12-02 19:28 ` Kei Kebreau
2018-12-02 21:18 ` swedebugia
2018-12-03 1:07 ` Kei Kebreau
2018-12-04 14:17 ` Alex Vong
2018-12-04 20:53 ` Kei Kebreau
2018-12-06 5:30 ` Alex Vong
2018-12-06 15:42 ` Kei Kebreau
2018-12-06 17:50 ` Alex Vong
2018-12-07 15:52 ` Kei Kebreau
2018-12-08 18:23 ` Kei Kebreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mupfx4gg.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=alexvong1995@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.