From: "Ludovic Courtès" <ludo@gnu.org>
To: Pierre Langlois <pierre.langlois@gmx.com>
Cc: 34931@debbugs.gnu.org
Subject: [bug#34931] [PATCH 0/5] Add gPodder.
Date: Sat, 23 Mar 2019 18:17:22 +0100 [thread overview]
Message-ID: <87mullv7bx.fsf@gnu.org> (raw)
In-Reply-To: <20190321001143.21045-1-pierre.langlois@gmx.com> (Pierre Langlois's message of "Thu, 21 Mar 2019 00:11:43 +0000")
Hello Pierre!
Pierre Langlois <pierre.langlois@gmx.com> skribis:
> Here is a patch series to add gPodder [0] and its dependencies. Since
> we have a few packages from the same project I thought we'd add a new
> gpodder.scm file for them.
>
> What do you think?
I think it’s a good idea. All 5 patches LGTM.
Unfortunately, python-mygpoclient fails its tests for me:
--8<---------------cut here---------------start------------->8---
======================================================================
FAIL: test_BadRequest (mygpoclient.http_test.Test_HttpClient)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 158, in test_BadRequest
self.assertRaises(BadRequest, client.GET, path)
AssertionError: BadRequest not raised by GET
======================================================================
FAIL: test_GET (mygpoclient.http_test.Test_HttpClient)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 163, in test_GET
self.assertEquals(client.GET(path), self.RESPONSE)
AssertionError: b'' != b'Test_GET-HTTP-Response-Content'
======================================================================
FAIL: test_GET_after_PUT (mygpoclient.http_test.Test_HttpClient)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 200, in test_GET_after_PUT
self.assertEquals(client.GET(path), self.RESPONSE + str(i).encode('utf-8'))
AssertionError: b'' != b'Test_GET-HTTP-Response-Content0'
======================================================================
FAIL: test_NotFound (mygpoclient.http_test.Test_HttpClient)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 148, in test_NotFound
self.assertRaises(NotFound, client.GET, path)
AssertionError: NotFound not raised by GET
[…]
--8<---------------cut here---------------end--------------->8---
Could you take a look?
I’ve pushed the first three patches in the meantime.
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-03-23 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 0:11 [bug#34931] [PATCH 0/5] Add gPodder Pierre Langlois
2019-03-21 0:22 ` [bug#34931] [PATCH 1/5] gnu: libmygpo-qt: Move to new 'gpodder.scm' file Pierre Langlois
2019-03-21 0:22 ` [bug#34931] [PATCH 2/5] gnu: Add python-podcastparser Pierre Langlois
2019-03-21 0:22 ` [bug#34931] [PATCH 3/5] gnu: Add python-minimock Pierre Langlois
2019-03-21 0:22 ` [bug#34931] [PATCH 4/5] gnu: Add python-mygpoclient Pierre Langlois
2019-06-27 19:38 ` swedebugia
2019-06-27 22:33 ` Pierre Langlois
2019-06-28 6:11 ` Pierre Langlois
2019-03-21 0:22 ` [bug#34931] [PATCH 5/5] gnu: Add gPodder Pierre Langlois
2019-03-25 9:32 ` bug#34931: " Ludovic Courtès
2019-03-23 17:17 ` Ludovic Courtès [this message]
2019-03-24 13:27 ` [bug#34931] [PATCH 0/5] " Pierre Langlois
2019-03-24 14:24 ` Pierre Langlois
2019-03-24 16:29 ` Pierre Langlois
2019-03-25 9:26 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mullv7bx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=34931@debbugs.gnu.org \
--cc=pierre.langlois@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.