all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: swedebugia <swedebugia@riseup.net>, guix-devel <guix-devel@gnu.org>
Subject: Re: Quicklisp importer bug in tarball->extract->parse
Date: Thu, 11 Apr 2019 16:31:06 +0200	[thread overview]
Message-ID: <87mukwlil1.fsf@ambrevar.xyz> (raw)
In-Reply-To: <874l7fzdbp.fsf@ambrevar.xyz>

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

Hi!

I've had time to look at it a little.

If you want to debug, you can, for instance, put a breakpoint in
guess-requirements-from-source, then enter the following in your guile
prompt:

  ,backtrace #:full? #t

or shorter

  ,bt #:full? #t

That will print the backtrace will all local variables.


There is nothing wrong with find-files: the "dir" directory is empty.
This is because the extraction failed: 
check the exit-code of system* before proceeding, you'll see what
happens ;)

--8<---------------cut here---------------start------------->8---
(system* "tar" "xf" tarball "-C" dir file-name)
--8<---------------cut here---------------end--------------->8---

The above will error out if "file-name" is not found.  For 1am:

Queried file-name:

  "1am.asd"

Tarball actual file:

  "1am-20141106-git/1am.asd"

I don't think we can predict the root folder, and more generally
projects have different trees.
So I suggest we extract the whole tarball and proceed from there.  So
your code should work by just removing "file-name":

--8<---------------cut here---------------start------------->8---
(system* "tar" "xf" tarball "-C" dir)
--8<---------------cut here---------------end--------------->8---

Makes sense?

Unrelated comment: If I'm not mistaken, you are fetching the meta-file
and the index-file on every query.  I suggest you keep those in memories
as soon as possible (memoize them), this will allow you to iterate much
faster when developing.

It seems that you are on the right track, great job!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2019-04-11 14:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29 20:07 Quicklisp importer bug in tarball->extract->parse swedebugia
2019-04-03  8:46 ` Pierre Neidhardt
2019-04-11 14:31   ` Pierre Neidhardt [this message]
2019-04-11 15:07     ` Ricardo Wurmus
2019-04-11 15:27       ` Pierre Neidhardt
2019-04-27  6:26     ` swedebugia
2019-04-27  7:15       ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mukwlil1.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=guix-devel@gnu.org \
    --cc=swedebugia@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.