From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 38320@debbugs.gnu.org, "Erik Edrosa" <erik.edrosa@gmail.com>,
"Clément Lassieur" <clement@lassieur.org>
Subject: bug#38320: Cuirass: Allow to use authenticated Git repositories as inputs
Date: Wed, 05 Feb 2020 22:24:42 +0100 [thread overview]
Message-ID: <87mu9wlobp.fsf@gnu.org> (raw)
In-Reply-To: <87v9oltobu.fsf@gmail.com> (Mathieu Othacehe's message of "Wed, 05 Feb 2020 09:45:09 +0100")
Hi!
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> Here's a version with optional authentication support. I do not find it
> too intrusive, but let me know what you think!
Yup, looks good!
> From 4554baf59564eb0c31cfe235acd078d54afef6d7 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Mon, 3 Feb 2020 18:05:02 +0100
> Subject: [PATCH] git: Add ssh authentication support.
>
> SSH agent authentication method is used.
>
> * guix/git.scm (auth-method): New variable,
> (clone*): pass previous variable in clone options,
> (update-cached-checkout): pass previous variable in fetch options.
[...]
> +;; Default authentication method.
> +(define auth-method (and auth-supported?
> + (%make-auth-ssh-agent)))
Perhaps we should not call it at the top level, in case it throws an
exception or has unwanted side effects? I’d suggest moving it to
the procedures where it’s used. Thoughts?
Apart from that it LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2020-02-05 21:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 9:51 bug#38320: Cuirass: Allow to use authenticated Git repositories as inputs Clément Lassieur
2019-11-25 13:42 ` Mathieu Othacehe
2019-11-25 13:46 ` Mathieu Othacehe
2019-11-28 23:46 ` Clément Lassieur
2019-11-26 10:05 ` Ludovic Courtès
2019-12-09 16:41 ` Mathieu Othacehe
2019-12-10 14:28 ` Ludovic Courtès
2019-12-11 0:28 ` Erik Edrosa
2019-12-12 13:13 ` Ludovic Courtès
2019-12-11 11:53 ` Mathieu Othacehe
2019-12-11 15:36 ` Clément Lassieur
2019-12-12 13:15 ` Ludovic Courtès
2020-02-04 9:16 ` Mathieu Othacehe
2020-02-04 12:58 ` Ludovic Courtès
2020-02-05 8:45 ` Mathieu Othacehe
2020-02-05 21:24 ` Ludovic Courtès [this message]
2020-02-06 15:16 ` Mathieu Othacehe
2020-02-06 17:17 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu9wlobp.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=38320@debbugs.gnu.org \
--cc=clement@lassieur.org \
--cc=erik.edrosa@gmail.com \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.