From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 40613-done@debbugs.gnu.org,
Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx>
Subject: bug#40613: [PATCH] gnu: Add emacs-typing.
Date: Thu, 22 Oct 2020 17:33:17 -0400 [thread overview]
Message-ID: <87mu0ec5eq.fsf@gmail.com> (raw)
In-Reply-To: <875ze13fkh.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 14 Apr 2020 23:47:26 +0200")
Hello Nicolas, Alberto,
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-typing): New variable.
>
> Thank you.
>
>> +(define-public emacs-typing
>> + (package
>> + (name "emacs-typing")
>> + (version "1.1.4")
>
> This is not a regular release, this is extracted from the main file. We
> need to provide a commit and a revision. See, e.g., "emacs-dhall-mode".
>
>> + (description "@code{emacs-typing} is a game for Emacs that
>
> I would write "The Typing of Emacs" instead of emacs-typing, i.e., the
> name of the game instead of the symbol.
>
>> +forces you to type words correctly as fast as possible, otherwise
>> +you will die. The game builds the list of words from the active buffer")
>
> The description is missing a final dot.
>
>> + (license license:gpl2)))
>
> The license is gpl2+.
>
> Could you send an updated patch?
I modified the original definition with your above suggestions and
pushed as commit a49bfa1f6c22363c9e495070f51b82e60b1495af.
Closing.
Thank you!
Maxim
prev parent reply other threads:[~2020-10-22 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 0:11 bug#40613: [PATCH] gnu: Add emacs-typing Alberto Eleuterio Flores Guerrero
2020-04-14 0:55 ` bug#40613: (no subject) Tobias Geerinckx-Rice
2020-04-14 21:47 ` bug#40613: [PATCH] gnu: Add emacs-typing Nicolas Goaziou
2020-10-22 21:33 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu0ec5eq.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=40613-done@debbugs.gnu.org \
--cc=barbanegra+guix@posteo.mx \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.