all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Z572 <873216071@qq.com>
Cc: 46015@debbugs.gnu.org
Subject: [bug#46015] [PATCH] Add xkeysnail.
Date: Fri, 29 Jan 2021 12:03:51 +0100	[thread overview]
Message-ID: <87mtwshunc.fsf@gnu.org> (raw)
In-Reply-To: <tencent_CA5EFF487438CA654A766B4736755333B309@qq.com> (873216071@qq.com's message of "Thu, 21 Jan 2021 18:40:27 +0800")

Hi,

Z572 <873216071@qq.com> skribis:

>>From c8ffb0e96851e5642fa872f5ffc20d9e56d30fb7 Mon Sep 17 00:00:00 2001
> From: Zheng Junjie <873216071@qq.com>
> Date: Thu, 21 Jan 2021 18:36:16 +0800
> Subject: [PATCH 1/2] gnu: Add python-inotify-simple.
>
> ---
>  gnu/packages/python-xyz.scm | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)

Applied with a commit log and without the Python 2 variant (we no longer
add them).

>>From ff3e5c516f7cae4cff3037cde5d36d7f415727dd Mon Sep 17 00:00:00 2001
> From: Zheng Junjie <873216071@qq.com>
> Date: Thu, 21 Jan 2021 18:37:33 +0800
> Subject: [PATCH 2/2] gnu: Add xkeysnail.
>
> ---
>  gnu/packages/xdisorg.scm | 31 ++++++++++++++++++++++++++++++-
>  1 file changed, 30 insertions(+), 1 deletion(-)

[...]

> +    (propagated-inputs
> +     `(("python-six" ,python-six)
> +       ("python-appdirs" ,python-appdirs)
> +       ("python-evdev" ,python-evdev)
> +       ("python-inotify-simple" ,python-inotify-simple)
> +       ("python-xlib" ,python-xlib)))

Please use ‘wrap-script’ around the ‘xkeysnail’ executable instead of
propagating inputs.  That way, installing xkeysnail won’t “pollute” the
user profile with all these Python libraries.

> +    (license license:gpl3)))

Is it version-3-only or version-3-or-any-later-version?

Could you send an updated patch?

Thanks,
Ludo’.




  reply	other threads:[~2021-01-29 11:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 10:40 [bug#46015] [PATCH] Add xkeysnail Z572
2021-01-21 10:40 ` Z572
2021-01-29 11:03   ` Ludovic Courtès [this message]
2021-01-29 11:04   ` Ludovic Courtès
2021-01-29 17:05 ` Z572
2021-01-29 17:05   ` Z572
2021-02-12  9:50     ` bug#46015: " 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtwshunc.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=46015@debbugs.gnu.org \
    --cc=873216071@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.