From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jai Vetrivelan <jaivetrivelan@gmail.com>
Cc: 54474@debbugs.gnu.org
Subject: [bug#54474] [PATCH 1/6] gnu: Add emacs-logos.
Date: Sun, 20 Mar 2022 14:30:28 +0100 [thread overview]
Message-ID: <87mthksqdn.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87v8w8bw4y.fsf@gmail.com> (Jai Vetrivelan's message of "Sun, 20 Mar 2022 18:48:05 +0530")
Hello,
Jai Vetrivelan <jaivetrivelan@gmail.com> writes:
> Subject: [PATCH 1/6] gnu: Add emacs-logos.
>
> * gnu/packages/emacs-xyz.scm (emacs-logos): New variable.
Thanks. Some comments follow.
> (source (origin
> (method git-fetch)
> (uri (git-reference
> (url "https://gitlab.com/protesilaos/logos.git/")
You can drop the ".git" suffix, as mentioned by "guix lint".
> + (arguments
> + `(#:phases
You should use G-expressions here, if only to avoid writing
(assoc-ref outputs "out")
which is too low level.
So:
(arguments
(list
#:phases
#~(modifiy phases ...)))
> + (modify-phases %standard-phases
> + (add-after 'install 'makeinfo
> + (lambda* (#:key outputs #:allow-other-keys)
Here, this would become
(lambda _
...)
> + (invoke "emacs"
> + "--batch"
> + "--eval=(require 'ox-texinfo)"
> + "--eval=(find-file \"README.org\")"
> + "--eval=(org-texinfo-export-to-info)")
> + (install-file "logos.info"
> + (string-append (assoc-ref outputs "out")
> + "/share/info")))))))
And here:
(install-file "logos.info" (string-append #$output "/share/info"))
The same goes for other packages.
Could you send updated patches?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-03-20 13:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 13:15 [bug#54474] [PATCH 0/6] gnu: emacs-xyz: Add info manuals of packages Jai Vetrivelan
2022-03-20 13:18 ` [bug#54474] [PATCH 1/6] gnu: Add emacs-logos Jai Vetrivelan
2022-03-20 13:22 ` Maxime Devos
2022-03-20 13:33 ` Jai Vetrivelan
2022-03-20 13:43 ` Maxime Devos
2022-03-20 13:22 ` Maxime Devos
2022-03-20 13:30 ` Nicolas Goaziou [this message]
2022-03-20 13:19 ` [bug#54474] [PATCH 2/6] gnu: Add emacs-pulsar Jai Vetrivelan
2022-03-20 13:20 ` [bug#54474] [PATCH 3/6] gnu: Add emacs-lin Jai Vetrivelan
2022-03-20 13:21 ` [bug#54474] [PATCH 4/6] gnu: Add emacs-tmr Jai Vetrivelan
2022-03-20 13:22 ` [bug#54474] [PATCH 5/6] gnu: emacs-modus-themes: Add Info manual Jai Vetrivelan
2022-03-20 13:22 ` [bug#54474] [PATCH 6/6] gnu: emacs-mct: " Jai Vetrivelan
2022-03-20 14:40 ` [bug#54474] [PATCH 1/6] gnu: Add emacs-pulsar Jai Vetrivelan
2022-03-20 14:40 ` [bug#54474] [PATCH 2/6] gnu: Add emacs-lin Jai Vetrivelan
2022-03-20 14:40 ` [bug#54474] [PATCH 3/6] gnu: Add emacs-logos Jai Vetrivelan
2022-03-20 14:40 ` [bug#54474] [PATCH 4/6] gnu: Add emacs-tmr Jai Vetrivelan
2022-03-20 14:40 ` [bug#54474] [PATCH 5/6] gnu: emacs-modus-themes: Add Info manual Jai Vetrivelan
2022-03-20 14:40 ` [bug#54474] [PATCH 6/6] gnu: emacs-mct: " Jai Vetrivelan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mthksqdn.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=54474@debbugs.gnu.org \
--cc=jaivetrivelan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.