From: Ricardo Wurmus <rekado@elephly.net>
To: 70877@debbugs.gnu.org
Cc: ludo@gnu.org
Subject: bug#70877: guix-daemon fails to copy 4+GB file to store
Date: Sat, 11 May 2024 12:52:53 +0200 [thread overview]
Message-ID: <87msowpqm2.fsf@elephly.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
The guix-daemon's libutil/util.cc uses copy_file_range to copy a
downloaded file into the store. copy_file_range fails on files larger
than 4GB with an error like this:
guix build: error: short write in copy_file_range `15' to `16': No such file or directory
The man page for copy_file_range says that it could return EFBIG when
the range exceeds the maximum range. The daemon code does not check any
limits and will attempt to copy the whole file.
I believe our code ought to check the value of st.size and fall back to
a boring copy if it exceeds some "reasonable" value.
This is where copy_file_range is used:
https://git.savannah.gnu.org/cgit/guix.git/tree/nix/libutil/util.cc#n382
Here is a little reproducer:
[-- Attachment #2: bug.scm --]
[-- Type: text/plain, Size: 425 bytes --]
(use-modules (guix download)
(guix packages)
(guix build-system trivial))
(package
(name "chungus")
(version "1")
(source
(origin
(method url-fetch)
(uri "http://localhost:1111/chungus")
(sha256
(base32 "0nx67d4ls2nfwcfdmg81vf240z6lpwpdqypssr1wzn3hyz4szci4"))))
(build-system trivial-build-system)
(home-page "")
(synopsis "")
(description "")
(license #f))
[-- Attachment #3: Type: text/plain, Size: 468 bytes --]
--8<---------------cut here---------------start------------->8---
# generate a big file
dd bs=1M count=4096 if=/dev/zero of=/tmp/chungus
# serve it
guix shell woof -- woof -i 127.0.0.1 -p 1111 -c 1 /tmp/chungus
# build the source derivation
guix build --no-grafts -Sf bug.scm
# observe the error
# guix build: error: short write in copy_file_range `15' to `16': No such file or directory
--8<---------------cut here---------------end--------------->8---
--
Ricardo
next reply other threads:[~2024-05-11 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 10:52 Ricardo Wurmus [this message]
2024-05-12 7:12 ` bug#70877: guix-daemon fails to copy 4+GB file to store Efraim Flashner
2024-05-13 10:10 ` Ludovic Courtès
2024-05-13 12:09 ` Ricardo Wurmus
2024-05-13 14:34 ` Ludovic Courtès
2024-05-13 16:24 ` Ludovic Courtès
2024-05-14 22:26 ` [bug#70398] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msowpqm2.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=70877@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.