Re: [Patch] Remove unused lambda arguments and prefer separate phases over augmented phases.

[ludo@gnu.org (Ludovic Courtès)]

Eric Bavier <ericbavier@gmail.com> skribis:

> My previous patch raised the question about whether it's wise to use
> something like::
>
> #:phases
> (alist-replace
>  'foo
>  (lambda* (#:key #:allow-other-keys #:rest args)
>    (let ((foo (assoc-ref 'foo %standard-phases)))
>     (frobnicate)
>     (apply foo args))))
>
> in recipe arguments, or to just add another phase before the foo phase.
>
> There was some concensus that adding another phase before or after was
> easier to understand (and less verbose), so I went ahead and tried to
> reformulate the package recipes that did such things.  Along the way I
> "cleaned up" some other things, mostly in the package arguments.
>
> I tried not to change anything semantically in the packate definitions,
> but I did verify that all packages build with these changes.

Nice, thanks for the taking the time to do that.

Mark and Andreas were fine with the idea, so OK to push, given that
you’ve already tested it.

> From d92b819c12b873fc3b99ec6771049a6bc4badbac Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sun, 30 Mar 2014 18:09:10 -0500
> Subject: [PATCH] gnu: Remove unused lambda arguments and prefer separate
>  phases over augmented phases.
>
> * gnu/packages/compression.scm (sharutils) [argumets]: Remove unused

“arguments”

> * gnu/packages/gl.scm (mesa) [arguments]: Same
> * gnu/packages/fltk.scm [arguments]: Same.  Substitute const check
>   phase with #:tests? #f.  Add pre-configure phase.
> * gnu/packages/ghostscript.scm (ghostscript) [arguments]: Put makefile
>   patches in separate phase.  Put so steps oi separate phases.

Typo.

> * gnu/packages/gnupg.scm (gnupg) [arguments]: Put patch in
>   pre-configure phase.
> (pius) [arguments]: Delete const #t configure and build phases.
> (signing-party) [arguments]: Factor patches into post-unpack phase.
> (paperkey) [arguments]: Remove unused lambda args.  Factor out patches
> into pre-check phase.

This (and a couple of others below) should be indented, like those
above.

Thanks!

Ludo’.